-
Notifications
You must be signed in to change notification settings - Fork 399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: Updated shimmer method in benchmark tests #2281
test: Updated shimmer method in benchmark tests #2281
Conversation
…erHooks and removeHooks Signed-off-by: mrickard <maurice@mauricerickard.com>
…hmark tests Signed-off-by: mrickard <maurice@mauricerickard.com>
Signed-off-by: mrickard <maurice@mauricerickard.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2281 +/- ##
==========================================
- Coverage 96.27% 96.27% -0.01%
==========================================
Files 284 284
Lines 45230 45230
==========================================
- Hits 43544 43543 -1
- Misses 1686 1687 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Description
Benchmark tests have not been updated across several API changes, resulting in test failures. One such change was replacing shimmer's
patchModule
andunpatchModule
withregisterHooks
andremoveHooks
. In this PR, I'veregisterHooks
andremoveHooks
BenchmarkStats
constructor to log context about which tests are being run, in the event of an error.How to Test
npm run bench
will still throw some errors on promise and database tests, but will output benchmark data for several modules.Related Issues
Closes NR-171849