Fix inline require causes performance issues #2506
Conversation
|
|
1 similar comment
|
|
| @@ -8,6 +8,7 @@ const logger = require('../logger').child({ component: 'code-level-metrics' }) | |||
| const { isValidLength } = require('./byte-limit') | |||
| const symbols = require('../symbols') | |||
| const clmUtils = module.exports | |||
| const { funcInfo } = require('@contrast/fn-inspect') | |||
There was a problem hiding this comment.
this was required in a try/catch because this dep is optional. If hoisting the require to top solves the issue, we need to wrap this in a try/catch at the very least. but i'd like to see a repro case so i can dig into the root cause
|
@trenton05 we require conventional commits, can you please fix up your PR title at the very least because that's what we'll use on merge |
|
@trenton05 just following up. can you please provide a repro case so we can dig into the root cause and validate that this fix will be enough? |
|
@trenton05 I'm going to close this. there has been no response to my questions. If you can provide a reproduction case, please reopen this PR |
|
Sorry I don't have the time to setup a test. A simple express server handling requests can easily be benchmarked. I made this PR to let your team know it was a serious issue on our end and this resolved it for us. |
Ok i'll see if I can reproduce and follow up |
|
@trenton05 I used a simple express server and ran 1000 requests with and without this change and see no difference in response time. const newrelic = require('newrelic')
const express = require('express')
const app = express()
const { PORT = 3000 } = process.env
app.get('/named-route', (req, res) => {
res.send('hi')
})
app.listen(PORT, () => console.log(`Example app listening on port ${PORT}!`))Something else in play for your case I think, it would be very helpful to provide a reproduction case |
Description
Please provide a brief description of the changes introduced in this pull request.
What problem does it solve? What is the context of this change?
The combination of code-level-metrics require('@contrast/fn-inspect') with @newrelic/ritm being hooked into requires causes a cascading load issue for nodejs.
How to Test
Please describe how you have tested these changes. Have you run the code against an example application?
What steps did you take to ensure that the changes are working correctly?
For reference, our express server with newrelic was taking 10 seconds to handle 500 requests. After this change, the same 500 requests takes about half a second. Should be able to be tested with a similar configuration.
Related Issues
Please include any related issues or pull requests in this section, using the format
Closes #<issue number>orFixes #<issue number>if applicable.Creating this to capture the issue and fix for the newrelic team, we have patched it locally so that we do not run across this issue anymore.