Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to v8 #10

Open
wants to merge 16 commits into
base: master
Choose a base branch
from
+288 −232
Open

Update to v8 #10

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
ef9f91f
Update event references.
asllop Sep 9, 2024
d4e94e8
Update player init instructions.
asllop Sep 9, 2024
3f8717b
Add support for DOWNLOAD event.
asllop Sep 9, 2024
1018e87
Stop logging verbose events.
asllop Sep 9, 2024
54e1d37
Fix playerVersion attribute.
asllop Sep 10, 2024
5d0903f
Fix unregisterListeners.
asllop Sep 10, 2024
7bc90c5
Add a separate ads tracker.
asllop Sep 17, 2024
927c6d5
Remove comment.
asllop Sep 17, 2024
094c0a4
Update attributes sent to error.
asllop Sep 18, 2024
602ef7e
Fix quartile attribute.
asllop Sep 18, 2024
693aa17
Update video core dependency.
asllop Sep 19, 2024
a895e22
Fix src attribute.
asllop Sep 19, 2024
21718dc
Fix strange issue.
asllop Sep 19, 2024
3a57aa1
Update ads usage sample.
asllop Sep 19, 2024
26f2481
Remove console logs.
asllop Sep 20, 2024
eef32f0
Fix unregister ad events.
asllop Sep 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove console logs.
  • Loading branch information
@asllop
asllop committed Sep 20, 2024
commit 26f248194ab8b13a0ac138c143d9a59877a6f23b
7 changes: 0 additions & 7 deletions src/ads.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@ export class BitmovinAdTracker extends nrvideo.VideoTracker {
// }

registerListeners () {
console.log("Ads registerListeners", this)
let ev = bitmovin.player.PlayerEvent

this.player.on(ev.AdBreakStarted, this.onAdBreakStarted.bind(this))
Expand All @@ -54,19 +53,14 @@ export class BitmovinAdTracker extends nrvideo.VideoTracker {
}

onAdBreakStarted (ev) {
console.log("Ad break started ev = ", ev)
this.sendAdBreakStart()
console.log("Ad tracker after sendAdBreakStart =", this)
}

onAdBreakFinished (ev) {
console.log("Ad break finished ev = ", ev, this)
console.log("Ad tracker before sendAdBreakEnd =", this)
this.sendAdBreakEnd()
}

onAdStarted (e) {
console.log("Ad srarted =", e)
this.sendRequest()
this.sendStart()
}
Expand All @@ -84,7 +78,6 @@ export class BitmovinAdTracker extends nrvideo.VideoTracker {
}

onAdQuartile (e) {
console.log("Quartile = ", e)
let q = 0;
switch (e.quartile) {
case "firstQuartile":
Expand Down
Loading