-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: fix default maxAge formula #7406
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
@vixeven is attempting to deploy a commit to the authjs Team on Vercel. A member of the Team first needs to authorize it. |
github-actions
bot
added
core
Refers to `@auth/core`
legacy
Refers to `next-auth` v4. Minimal maintenance.
labels
Apr 30, 2023
balazsorban44
approved these changes
Apr 30, 2023
ThangHuuVu
pushed a commit
that referenced
this pull request
May 3, 2023
balazsorban44
added a commit
that referenced
this pull request
May 4, 2023
* docs: Remove --save from install command (#7277) Remove --save from install command --save is no longer needed on npm install. * chore: fix "Contributing guide" link (#7279) * fix: detect origin when `instanceof Request` check fails (#7303) * docs: Update Clerk sponsorship URL (#7305) - Change Clerk URL from `https://clerk.dev` to `https://clerk.com` - Fix alt from copy/paste * chore: bump react types * fix(docs): fix default `maxAge` formula (#7406) * Update pnpm-lock.yaml * sync package.json change --------- Co-authored-by: Chris Hayes <6013871+Christopher-Hayes@users.noreply.github.com> Co-authored-by: Raul <57044803+Leprekus@users.noreply.github.com> Co-authored-by: Balázs Orbán <info@balazsorban.com> Co-authored-by: Nick Parsons <nparsons08@gmail.com> Co-authored-by: Victor <saptefrativictor@gmail.com>
balazsorban44
pushed a commit
that referenced
this pull request
Jun 1, 2023
ThangHuuVu
added a commit
that referenced
this pull request
Sep 23, 2023
* feat(adapter-surrealdb): implemented with unit tests * chore: update README * Use stateless DB connection * Update surrealdb-rest-ts * chore: bump turbo and pnpm * chore(docs): fix dynamodb typo (#7130) fix: typo * chore: bump pnpm * chore: update lock file, bump dev dependencies * chore: run `pnpm install --fix-lockfile` * chore: re-run pnpm install * chore: add missing dev dep * revert lock * update lock * use surrealdb.js * add rest test * remove commented-out code * update readme * modularize repeated code * fix(docs): fix default `maxAge` formula (#7406) * feat(adapters): add Account mapping before database write (#7369) * feat: map Account before saving to database * document `acconut()`, explain default behaviour * generate `expires_at` based on `expires_in` Fixes #6538 * rename * strip undefined on `defaultProfile` * don't forward defaults to account callback * improve internal namings, types, docs * chore: improve errors, add more docs (#7415) * JWT Token -> JWT * document some errors * improve errors, docs * fix: loosen profile types * chore: type fixes * fix: allow handling OAuth callback error response related #7407 * fix(docs): remove extra heading Fixes #7426 * chore: use `@ts-ignore` * chore: support release any package as experimental * chore: separate manual release job * chore: skip test for manual release * chore: tweak * chore: tweaks * chore: tweak manual release version * Use query instead of select to be able to use query params * Fix lint errors * Update surrealdb.js and remove surrealdb-rest-ts in favor of ExperimentalSurrealHTTP * update pnpm-lock * fix merge * fix merge * fix merge * migrate surrealdb.js api * fix queries * update package.json * fix types * prepare for rest * update readme * chore: format PR * Update README.md * Update package.json --------- Co-authored-by: Balázs Orbán <info@balazsorban.com> Co-authored-by: jakzo <jack@jf.id.au> Co-authored-by: Victor <saptefrativictor@gmail.com> Co-authored-by: Thang Vu <hi@thvu.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☕️ Reasoning
The formula provided in the documentation for
maxAge
is incorrect.🧢 Checklist