V4 dev app: fix broken import links for authOptions #8938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goerlitz
requested review from
ubbe-xyz,
ndom91 and
ThangHuuVu
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
|
@goerlitz is attempting to deploy a commit to the authjs Team on Vercel. A member of the Team first needs to authorize it. |
ThangHuuVu
approved these changes
Nov 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix broken authOptions import paths pointing to outdated file.
☕️ Reasoning
There are two files defining the authOptions in the dev app:
apps/dev/app/api/auth/[...nextauth]/route.ts-> most recent versionapps/dev/pages/api/auth-old/[...nextauth].ts-> outdated version with folder renamed to `auth-old``However, several pages (e.g.
apps/dev/pages/api/examples/protected.js) were still importing the outdated version in the oldauthfolder (before renaming). Thus, the dev app (pnpm dev) would not work properly and throw errors.🧢 Checklist
🎫 Affected issues
Fixes: #8934