Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!(humanFileSize): Revert changes to default file sizes #822

Merged
merged 1 commit into from
Nov 3, 2023

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Nov 2, 2023

(use binary sizes but decimal units)

For Nextcloud the current default is using binary sizes, like 1024 or 2048, but showing decimal units. Meaning 1024 bytes = 1 KB, like done on Windows and not like on Linux 1024 bytes = 1 KiB. There is also the option to show like on Apple: 1000 bytes = 1 KB and 1024 bytes = 1.024 KB

This is (again) breaking

… sizes but decimal units)

For Nextcloud the current default is using binary sizes, like 1024 or 2048, but showing decimal units.
Meaning 1024 bytes = 1 KB, like done on Windows and not like on Linux 1024 bytes = 1 KiB.
There is also the option to show like on Apple: 1000 bytes = 1 KB and 1024 bytes = 1.024 KB

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Copy link

codecov bot commented Nov 2, 2023

Codecov Report

Merging #822 (55065db) into master (5a568e2) will increase coverage by 0.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #822      +/-   ##
==========================================
+ Coverage   78.01%   78.06%   +0.05%     
==========================================
  Files          17       17              
  Lines         423      424       +1     
  Branches      112      113       +1     
==========================================
+ Hits          330      331       +1     
  Misses         93       93              
Files Coverage Δ
lib/humanfilesize.ts 96.29% <100.00%> (+0.14%) ⬆️

Copy link
Contributor

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@susnux susnux merged commit 29c15fc into master Nov 3, 2023
10 checks passed
@susnux susnux deleted the fix/files-sizes branch November 3, 2023 13:46
This was referenced Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants