Add docs and tests for #2973 #2990
Conversation
|
/backport to stable5 |
| @@ -20,6 +20,7 @@ | |||
| "lint": "eslint --ext .js,.vue src", | |||
| "lint:fix": "eslint --ext .js,.vue src --fix", | |||
| "test": "jest --verbose", | |||
| "test:coverage": "jest --verbose --coverage --no-cache", | |||
There was a problem hiding this comment.
Is this necessary?
There was a problem hiding this comment.
I used make test-coverage and noticed this command doesn't work because the script test:coverage wasn't present so i fixed this. It's not necessary but i think it's nice if the Makefile stages work :-)
Thank's for your quick feedback. Could you tell me what exactly does not work and how you tested this? Then i'll try to reproduce the issue. Thank you |
The MultiselectTags of your examples are not shown in the docs preview. See https://deploy-preview-2990--nextcloud-vue-components.netlify.app/#/Components/Multiselect?id=multiselecttags |
Ah okay, now i see. I didn't realize that the examples are interactive so my sample code is incomplete. Will fix this, thank's for pointing out. |
R0Wi
force-pushed
the
feature/add-docs-tests#2973
branch
from
8117bc8
to
aa98906
Compare
Signed-off-by: R0Wi <ro.windey@gmail.com>
Signed-off-by: R0Wi <ro.windey@gmail.com>
R0Wi
force-pushed
the
feature/add-docs-tests#2973
branch
from
aa98906
to
0e8ccc2
Compare
|
Missunderstood the docs code. I think now it should be fixed 👍 |
Signed-off-by: Raimund Schlüßler <raimund.schluessler@mailbox.org> Signed-off-by: Raimund Schlüßler <raimund.schluessler+github@mailbox.org>
Like discussed in #2973