Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tag search #3747

Merged
merged 2 commits into from
Feb 14, 2023
Merged

Fix tag search #3747

merged 2 commits into from
Feb 14, 2023

Conversation

Pytal
Copy link
Contributor

@Pytal Pytal commented Feb 14, 2023

Fix #3662 and make minor updates to vue-select prop handling

The limit prop is now used instead of optionsFilter to limit the available tags

Previously only 5 tags were being passed as options to VueSelect, since VueSelect handles searching internally any tag after the 5th one could not be searched for

Before After
image image

Signed-off-by: Christopher Ng <chrng8@gmail.com>
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal Pytal added bug Something isn't working feature: select Related to the NcSelect* components labels Feb 14, 2023
@Pytal Pytal added this to the 7.6.0 milestone Feb 14, 2023
@Pytal Pytal self-assigned this Feb 14, 2023
@Pytal Pytal requested a review from szaimen February 14, 2023 02:41
Copy link
Contributor

@raimund-schluessler raimund-schluessler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works.
But I have to admit, I find it weird to see only 5 tags in the dropdown and then new tags showing up when I filter. But that's a different story, I guess.

@nickvergessen
Copy link
Contributor

But that's a different story, I guess.

It's a browser performance thing :)
Otherwise when you have thousands of tags (automated tagging from AI and things) they slow down the page loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working feature: select Related to the NcSelect* components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tag search does not work anymore
4 participants