-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(NcModal): Close button should be visible even if modal content is scrolled #4350
Conversation
… scrolled. Fixes #3118 Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux Awesome that you included tests, but Runner2 gives this error:
However, it passes anyway, so I don't know what the error means 🙈 |
It means Typescript is missing the type definitions for that vue file, as it is written in Javascript and we do not provide any typings for it. I think to silence that issue I will have to add a declaration shim for tests :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested in calendar and works.
Some hacks need to be reverted and I added a note to #4223.
Exemplary patch for calendar
diff --git a/css/app-settings.scss b/css/app-settings.scss
index 5e96ae0e6..5ae9a0744 100644
--- a/css/app-settings.scss
+++ b/css/app-settings.scss
@@ -86,8 +86,6 @@
.shortcut-overview-modal {
.modal-container {
- display: flex !important;
- flex-wrap: wrap;
padding: 0 12px 12px 12px !important;
* {
/backport to stable7 |
Raised an issue 4627 for tracking this |
☑️ Resolves
Ensures that the close button of the modal is always visible, even if the content overflows the container and is scrolled.
🧪 Cypress test included.
🏁 Checklist