fix(CI): Make sure the "when unrelated" fake summaries work correctly #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before they executed when any file outside the defined scope matched. However that means: When a PR touches PHP and JS, both the real and the fake summaries for node, eslint and phpunit got triggered. Since the fake summary is always green it meant one could merge a PR that in the end had red CI on the non-fake summary. Now the fake summaries are skipped, if any of the files still matches the pattern, instead of being executed whenever a single file did not match it. Signed-off-by: Joas Schilling <coding@schilljs.com>
nickvergessen
added
3. to review
skjnldsv
approved these changes
Sep 28, 2023
max-nextcloud
approved these changes
Oct 2, 2023
|
So, this or you want to port your logic @kesselb |
|
Tough question 😰 I used the GitHub action dorny/paths-filter to run phpunit only for php* changes at https://github.com/nextcloud/server/pull/39734/files. One advantage is that we only have one workflow. I find that easier to understand and maintain. The disadvantage is that the workflow itself is more complex because we have the additional job to evaluating the changed files and another check for the summary step. What do you think @skjnldsv @max-nextcloud @ChristophWurst? |
kesselb
reviewed
Oct 10, 2023
nickvergessen
force-pushed
the
bugfix/noid/fix-unrelated-ci
branch
from
25accf4
to
8a9fa2e
Compare
… the changed files Signed-off-by: Joas Schilling <coding@schilljs.com>
nickvergessen
force-pushed
the
bugfix/noid/fix-unrelated-ci
branch
from
8a9fa2e
to
b7e53a6
Compare
kesselb
approved these changes
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before they executed when any file outside the defined scope matched. However that means: When a PR touches PHP and JS, both the real and the fake summaries for node, eslint and phpunit got triggered. Since the fake summary is always green it meant one could merge a PR that in the end had red CI on the non-fake summary.
Now the fake summaries are skipped, if any of the files still matches the pattern, instead of being executed whenever a single file did not match it.
How did I notice
Reason
https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#example-excluding-paths
There was some file that didn't match, so that's why the "when unrelated" ran... that's .... problematic.
"When unrelated" should only run, when none of the matching files was touched.
Debug
Debugged this in https://github.com/nickvergessen/turbo-lamp/pulls
Possible improvements
Read the .yml file and use the
on.pull_request.paths-ignoreinstead of duplicating the paths into the env. But I was unable to achieve that and this solution here works good enough for now.