-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix missing parameters when type is not "known" #1468
Conversation
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
/backport 2a2939f,f77b042f423308688dd3e5d51840d80d9ff7126b to stable28 |
/compile amend |
Compilation CI seem off on this repo, not sure why |
Signed-off-by: Joas Schilling <coding@schilljs.com> Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
7a0b7dd
to
4e40ec0
Compare
If you compile with the compile command it works, if you compile locally it does not :/ |
From my experience, the compile command also fails. |
The main difference to other repos is this here uses vite not eslint/webpack for building? |
Assets are named by the content hash thus the content seems to be different between those builds |
Currently the fall backs from https://github.com/nextcloud/activity/blob/stable27/js/richObjectStringParser.js#L82-L87 are missing breaking activity of calendar, deck, talk, …