Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Harmonize paddings to make links not truncated #1482

Merged
merged 1 commit into from
Dec 28, 2023

Conversation

JuliaKirschenheuter
Copy link
Contributor

Resolves #1481

🖼️ Screenshots

Before After
image Screenshot from 2023-12-28 10-41-19
Screenshot from 2023-12-28 10-02-12 Screenshot from 2023-12-28 10-02-57

@JuliaKirschenheuter
Copy link
Contributor Author

/backport to stable28

@JuliaKirschenheuter
Copy link
Contributor Author

/compile amend /

@nextcloud-command nextcloud-command force-pushed the fix/1481-focused_links_are_truncated_on_400%_zoom branch from fca7d0b to 0995dce Compare December 28, 2023 09:54
Signed-off-by: julia.kirschenheuter <julia.kirschenheuter@nextcloud.com>
@JuliaKirschenheuter JuliaKirschenheuter force-pushed the fix/1481-focused_links_are_truncated_on_400%_zoom branch from 0995dce to b276113 Compare December 28, 2023 10:57
Copy link
Contributor

@emoral435 emoral435 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@emoral435 emoral435 merged commit 44ad0d1 into master Dec 28, 2023
43 checks passed
@emoral435 emoral435 deleted the fix/1481-focused_links_are_truncated_on_400%_zoom branch December 28, 2023 16:22
@backportbot-nextcloud
Copy link

The backport to stable28 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable28
git pull origin stable28

# Create the new backport branch
git checkout -b fix/foo-stable28

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable28

Error: Unknown error

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BITV]: focused links are truncated on 400% zoom
2 participants