Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove horizontal scrolling for activity view #1483

Conversation

JuliaKirschenheuter
Copy link
Contributor

Resolves #1480

🖼️ Screenshots

Before After
Screenshot from 2023-12-28 10-49-45 Screenshot from 2023-12-28 10-49-34

@JuliaKirschenheuter
Copy link
Contributor Author

/backport to stable28

@JuliaKirschenheuter
Copy link
Contributor Author

/compile amend /

@nextcloud-command nextcloud-command force-pushed the fix/1480-Remove_horizontal_scrolling_for_activity_view branch from 323d654 to 5c1e05b Compare December 28, 2023 09:54
@JuliaKirschenheuter JuliaKirschenheuter force-pushed the fix/1480-Remove_horizontal_scrolling_for_activity_view branch from 5c1e05b to 6b118dd Compare December 28, 2023 10:55
@JuliaKirschenheuter
Copy link
Contributor Author

/compile amend /

@nextcloud-command nextcloud-command force-pushed the fix/1480-Remove_horizontal_scrolling_for_activity_view branch from 6b118dd to 42d5306 Compare December 28, 2023 12:25
Copy link
Contributor

@emoral435 emoral435 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on my local dev env, works, and LGTM!

@JuliaKirschenheuter JuliaKirschenheuter force-pushed the fix/1480-Remove_horizontal_scrolling_for_activity_view branch from 42d5306 to d0830ee Compare December 28, 2023 16:48
@JuliaKirschenheuter
Copy link
Contributor Author

/compile amend /

@nextcloud-command nextcloud-command force-pushed the fix/1480-Remove_horizontal_scrolling_for_activity_view branch from d0830ee to 1ac7d3e Compare December 28, 2023 17:09
Copy link
Collaborator

@artonge artonge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't this solution crops the content of the activity if it overflows?

@JuliaKirschenheuter JuliaKirschenheuter force-pushed the fix/1480-Remove_horizontal_scrolling_for_activity_view branch from 1ac7d3e to 4f5852b Compare January 3, 2024 18:13
Copy link

cypress bot commented Jan 3, 2024

1 flaky test on run #1077 ↗︎

0 10 0 0 Flakiness 1

Details:

Remove horizontal scrolling for activity view
Project: Activity Commit: 188e94678a
Status: Passed Duration: 02:56 💡
Started: Jan 5, 2024 7:49 AM Ended: Jan 5, 2024 7:52 AM
Flakiness  cypress/e2e/sidebar.cy.ts • 1 flaky test • Run E2E

View Output

Test Artifacts
Check activity listing in the sidebar > Has move activity Test Replay Screenshots

Review all test suite changes for PR #1483 ↗︎

@emoral435 emoral435 force-pushed the fix/1480-Remove_horizontal_scrolling_for_activity_view branch from 4f5852b to 8a7ab04 Compare January 3, 2024 20:04
Copy link
Contributor

@emoral435 emoral435 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Check the console, it seems like some of the changes have affected how some of the components render :(

@JuliaKirschenheuter
Copy link
Contributor Author

Check the console, it seems like some of the changes have affected how some of the components render :(

All i've changed for this PR were 2 lines of css. This is a problem, but not related to PR

@ShGKme
Copy link
Contributor

ShGKme commented Jan 4, 2024

/compile amend

Signed-off-by: julia.kirschenheuter <julia.kirschenheuter@nextcloud.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@nextcloud-command nextcloud-command force-pushed the fix/1480-Remove_horizontal_scrolling_for_activity_view branch from 8a7ab04 to d8fab4f Compare January 4, 2024 15:56
Copy link
Contributor

@emoral435 emoral435 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the confusion on my end, LGTM!

@JuliaKirschenheuter JuliaKirschenheuter merged commit 7f3e1ed into master Jan 5, 2024
43 checks passed
@JuliaKirschenheuter JuliaKirschenheuter deleted the fix/1480-Remove_horizontal_scrolling_for_activity_view branch January 5, 2024 08:29
@backportbot-nextcloud
Copy link

The backport to stable28 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable28
git pull origin stable28

# Create the new backport branch
git checkout -b fix/foo-stable28

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable28

Error: Unknown error

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BITV]: Remove horizontal scrolling for activity view
4 participants