fix: Replace deprecated function calls and private with public API

[susnux]

• Replace deprecated execute with executeQuery or executeStatement.
• Replace private OC\BackgroundJob\... with public OCP\BackgroundJob\...
• Do not use private \OC::$server but use dependency injection

[cypress]

1 flaky test on run #1172 ↗︎

0

10

0

0

1

Details:

fix: Replace deprecated function calls and private with public API
Project: Activity	Commit: 5114e4d5a9
Status: Passed	Duration: 03:08 💡
Started: Jan 17, 2024 11:51 AM	Ended: Jan 17, 2024 11:54 AM

  cypress/e2e/sidebar.cy.ts • 1 flaky test • Run E2E

View Output

Test		Artifacts
Check activity listing in the sidebar > Has favorite activity		Test Replay Screenshots

Review all test suite changes for PR #1519 ↗︎

[nickvergessen]

💥 This breaks the digest cron job

[nickvergessen]

{"Exception":"Error","Message":"Typed property OCP\\BackgroundJob\\Job::$time must not be accessed before initialization",

[github-actions]

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!