Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable29] Remove requiring PNG for iOS #1795

Merged
merged 1 commit into from
Sep 23, 2024
Merged

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented Sep 20, 2024

Backport of PR #1793

Signed-off-by: Milen Pivchev <milen.pivchev@gmail.com>
Copy link

cypress bot commented Sep 20, 2024

Activity    Run #2001

Run Properties:  status check failed Failed #2001  •  git commit 04fbdc770f: [stable29] Remove requiring PNG for iOS
Project Activity
Branch Review backport/1793/stable29
Run status status check failed Failed #2001
Run duration 06m 34s
Commit git commit 04fbdc770f: [stable29] Remove requiring PNG for iOS
Committer backportbot[bot]
View all properties for this run ↗︎

Test results
Tests that failed  Failures 2
Tests that were flaky  Flaky 3
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 8
View all changes introduced in this branch ↗︎

Tests for review

Failed  cypress/e2e/sidebar.cy.ts • 2 failed tests • Run E2E

View Output

Test Artifacts
Check activity listing in the sidebar > Has rename activity Test Replay Screenshots
Check activity listing in the sidebar > Has comment activity Test Replay Screenshots
Flakiness  sidebar.cy.ts • 2 flaky tests • Run E2E

View Output

Test Artifacts
Check activity listing in the sidebar > Has favorite activity Test Replay Screenshots
Check activity listing in the sidebar > Has tag activity Test Replay Screenshots
Flakiness  settings.cy.ts • 1 flaky test • Run E2E

View Output

Test Artifacts
Check that user's settings survive a reload > Form survive a reload Test Replay Screenshots

@artonge artonge merged commit 3c40d81 into stable29 Sep 23, 2024
42 of 44 checks passed
@artonge artonge deleted the backport/1793/stable29 branch September 23, 2024 09:43
@Altahrim Altahrim mentioned this pull request Oct 1, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants