Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/remote activity constructor #1811

Merged
merged 2 commits into from
Oct 14, 2024
Merged

Conversation

juliushaertl
Copy link
Member

@juliushaertl juliushaertl commented Oct 14, 2024

The queued job class requires to pass an ITimeFactory to its constructor, otherwise we may see errors like:

Typed property OCP\BackgroundJob\Job::$time must not be accessed before initialization

Seen logged on our instance 18k times in the last 90 days

Signed-off-by: Julius Knorr <jus@bitgrid.net>
Signed-off-by: Julius Knorr <jus@bitgrid.net>
@juliushaertl
Copy link
Member Author

/backport to stable30

@juliushaertl
Copy link
Member Author

/backport a51d666 to stable29

@juliushaertl
Copy link
Member Author

/backport a51d666 to stable28

Copy link

cypress bot commented Oct 14, 2024

Activity    Run #2020

Run Properties:  status check passed Passed #2020  •  git commit cc9e2743a8: fix/remote activity constructor
Project Activity
Run status status check passed Passed #2020
Run duration 02m 46s
Commit git commit cc9e2743a8: fix/remote activity constructor
Committer Julius Knorr
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 1
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 10

@miaulalala miaulalala merged commit cb536ae into master Oct 14, 2024
50 checks passed
@miaulalala miaulalala deleted the fix/remote-activity-constructor branch October 14, 2024 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants