Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Webhooks methods to complement Stream and E-Mail notifications. #327

Closed
wants to merge 1 commit into from

Conversation

tinko92
Copy link

@tinko92 tinko92 commented Dec 10, 2018

The commit in this pull request adds the feature to send HTTP(S) requests to a URL that is specified in the admin settings as a notification for new activities, similar to the existing methods of sending notifications about new activities via stream or e-mail. The request contains information about the event in JSON format and optionally a secret string that can be set in the Admin settings and can be verified on the receiving end.

Signed-off-by: Tinko Bartels mail@tinkobartels.de

Signed-off-by: Tinko Bartels <mail@tinkobartels.de>
@MatthiasHertel
Copy link

@nickvergessen @icewind1991

hey why not merged ?
i think it would be nice to register more notification provider (slack webhook) for give a possiblity preventing load on mail server.

can u review it and merge ?

it would be nice :)

@nickvergessen
Copy link
Member

It might be revisited soon, as there are plans to change activity and notifications in something new

@nickvergessen
Copy link
Member

Closing this as in it's current state this is too far from being mergable.

  • Curl is used instead of Nextcloud's HTTP client, allowing SSRF
  • Webhook results are not signed with a shared secrect, so can not be validated on the recipient side for authenticy, instead the token is send directly as header
  • Settings were redone

A follow up approach should be similar to nextcloud/spreed#9458

@skjnldsv skjnldsv removed this from the Nextcloud 27 milestone May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants