Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't throw when we are deleting nothing #94

Merged

Conversation

nickvergessen
Copy link
Member

Signed-off-by: Joas Schilling <coding@schilljs.com>
@LukasReschke
Copy link
Member

We should probably backport this, right?

@nickvergessen nickvergessen merged commit f83a0d7 into master Dec 19, 2016
@nickvergessen nickvergessen deleted the issue-2688-error-on-empty-activity-mail-deletion branch December 19, 2016 09:09
@nickvergessen
Copy link
Member Author

Yes, backport is in #95

@tflidd
Copy link

tflidd commented Jan 1, 2017

@nickvergessen
Copy link
Member Author

Right, we backported the previous change: #54
So yes need to backport this to 10 as well

@nickvergessen
Copy link
Member Author

Done in #99

@JSoko
Copy link
Member

JSoko commented Jan 12, 2017

It seems that this fix isn't included in 11.0.1 RC1

@techc0de
Copy link

techc0de commented Jan 12, 2017

I'm using external storage without encryption, and I still having this errors.
The mp3/videos aren't play either while connect remotely.
This error didn't exist in NC10.

`imagecreatefromstring(): Empty string or invalid image at /media/54bf67db-da31-4c50-bb3c-27140944b223/www/nextcloud/lib/private/legacy/image.php#597

fclose() expects parameter 1 to be resource, boolean given at /media/54bf67db-da31-4c50-bb3c-27140944b223/www/nextcloud/lib/private/Files/Storage/Local.php#218

fread() expects parameter 1 to be resource, boolean given at /media/54bf67db-da31-4c50-bb3c-27140944b223/www/nextcloud/lib/private/Files/Storage/Local.php#217

fopen(/media/54bf67db-da31-4c50-bb3c-27140944b223/www/nextcloud/data/tien/files/media/54bf67db-da31-4c50-bb3c-27140944b223/www/nextcloud/core/img/filetypes/audio.svg): failed to open stream: No such file or directory at /media/54bf67db-da31-4c50-bb3c-27140944b223/www/nextcloud/lib/private/Files/Storage/Local.php#216

filesize(): stat failed for /media/54bf67db-da31-4c50-bb3c-27140944b223/www/nextcloud/data/tien/files/media/54bf67db-da31-4c50-bb3c-27140944b223/www/nextcloud/core/img/filetypes/audio.svg at /media/54bf67db-da31-4c50-bb3c-27140944b223/www/nextcloud/lib/private/Files/Storage/Local.php#211

fopen(/media/54bf67db-da31-4c50-bb3c-27140944b223/www/nextcloud/data/tien/files/media/54bf67db-da31-4c50-bb3c-27140944b223/www/nextcloud/core/img/filetypes/audio.svg): failed to open stream: No such file or directory at /media/54bf67db-da31-4c50-bb3c-27140944b223/www/nextcloud/lib/private/Files/Storage/Local.php#216


 filesize(): stat failed for /media/54bf67db-da31-4c50-bb3c-27140944b223/www/nextcloud/data/tien/files/media/54bf67db-da31-4c50-bb3c-27140944b223/www/nextcloud/core/img/filetypes/audio.svg at /media/54bf67db-da31-4c50-bb3c-27140944b223/www/nextcloud/lib/private/Files/Storage/Local.php#211`

@nickvergessen
Copy link
Member Author

Yeah, I merged it on the day after. But Should be included in RC2 (when we do one) or the final.

@techc0de
Copy link

Looking forward to it.
Thanks for the info.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants