Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aio-interface: adjust design for nc30 #5007

Merged
merged 3 commits into from
Aug 16, 2024
Merged

aio-interface: adjust design for nc30 #5007

merged 3 commits into from
Aug 16, 2024

Conversation

szaimen
Copy link
Collaborator

@szaimen szaimen commented Jul 19, 2024

Close #4955

@szaimen szaimen added 2. developing Work in progress design Related to design, interface, interaction design, UX, etc. enhancement New feature or request labels Jul 19, 2024
@szaimen szaimen force-pushed the enn/4955/adjust-design branch 2 times, most recently from 8fa5e2e to 89ab0af Compare July 19, 2024 09:35
@docjyJ docjyJ mentioned this pull request Jul 29, 2024
@docjyJ
Copy link
Collaborator

docjyJ commented Aug 8, 2024

Hi, are you open to a proposal?

@szaimen
Copy link
Collaborator Author

szaimen commented Aug 8, 2024

Hi, are you open to a proposal?

Hi @docjyJ, in general yes. :) What are you proposing?

@docjyJ
Copy link
Collaborator

docjyJ commented Aug 8, 2024

I pushed it, feel free to delete the commit.

It's just the blue border effect of the classic aio + manage paragraphs in the flex column.

See 00f6789

@szaimen
Copy link
Collaborator Author

szaimen commented Aug 8, 2024

Ah, I see... I currently cannot test this because I am on my phone... Can you post a screenshot?

@docjyJ
Copy link
Collaborator

docjyJ commented Aug 8, 2024

Without the title in the header ^^'
I'm working on stalwart I don't have the all-in-one project open

#5016 (comment)

@docjyJ
Copy link
Collaborator

docjyJ commented Aug 8, 2024

Without the title in the header ^^' I'm working on stalwart I don't have the all-in-one project open

#5016 (comment)

and without the dividers

php/public/style.css Outdated Show resolved Hide resolved
szaimen and others added 2 commits August 16, 2024 13:15
Signed-off-by: Simon L. <szaimen@e.mail.de>
Signed-off-by: Jean-Yves <7360784+docjyJ@users.noreply.github.com>
@szaimen szaimen force-pushed the enn/4955/adjust-design branch 6 times, most recently from 3f9c777 to 8f5562a Compare August 16, 2024 12:02
@szaimen szaimen marked this pull request as ready for review August 16, 2024 12:04
@szaimen szaimen added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Aug 16, 2024
This reverts parts of commit ef66df0.
Signed-off-by: Simon L. <szaimen@e.mail.de>
@szaimen
Copy link
Collaborator Author

szaimen commented Aug 16, 2024

Thanks @docjyJ I used some of your proposal and fixed some details :)

@szaimen szaimen merged commit 5318d66 into main Aug 16, 2024
6 checks passed
@szaimen szaimen deleted the enn/4955/adjust-design branch August 16, 2024 12:07
@szaimen
Copy link
Collaborator Author

szaimen commented Sep 4, 2024

This is now released with 9.5.0 Beta. Testing and feedback is welcome! See https://github.com/nextcloud/all-in-one#how-to-switch-the-channel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews design Related to design, interface, interaction design, UX, etc. enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adjust the design to fit nc30
2 participants