-
Notifications
You must be signed in to change notification settings - Fork 616
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ui): introducing dark-mode and refactor some templates and css #5397
base: main
Are you sure you want to change the base?
Conversation
12d5b36
to
0fc8d4a
Compare
0fc8d4a
to
0357477
Compare
Woow!!! Many thanks @ernolf for this amazing contribution🎉😊 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have some remarks though and leave it further down but looks really great already. Thanks again! :)
Looking good! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not tested, but it's cool!
The ideal would be to have a Vuejs front and a JSON API 🫢 🙄 |
If you don't know, on this site there are lots of tips including sync with OS https://css-tricks.com/a-complete-guide-to-dark-mode-on-the-web/ |
I am not sure about this. I think vuejs is overkill for such a small site. And it adds maintainability issues imho. |
0357477
to
2ad8fdf
Compare
2ad8fdf
to
1692b47
Compare
Btw @ernolf i think we need to increase v2 for upgrade scenarios: all-in-one/php/templates/layout.twig Line 4 in a647d10
|
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Lets maybe discuss this in a separate issue. Do you want to create an issue? |
See bf47628 |
bf47628
to
756cdcc
Compare
…d css - chore: increase to 9.7.0 - reconcile with main after rebase - chore: reconcile fixes to containers.twig from main after rebase - refactor(layout): increment CSS version from v2 to v3 Signed-off-by: ernolf <raphael.gradenwitz@googlemail.com>
756cdcc
to
1f144b9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks a lot 💙
This needs to wait for the next stable release though before it can be merged (ca. 1 week)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Introducing dark-mode
AIO-dark-mode.webm