Proof of concept for Single Sign On

[tobiasKaminsky]

by @David-Development
Ref: nextcloud/Android-SingleSignOn#3

[AndyScherzinger]

@tobiasKaminsky @David-Development any change to get this updated to latest master? This would be a nice post-2.0.0 addition :)

cc @mario

[tobiasKaminsky]

@David-Development lint is complaining:

Exported services (services which either set exported=true or contain an intent-filter and do not specify exported=false) should define a permission that an entity must have in order to launch the service or bind to it. Without this, any application can use this service.
Note: This issue has an associated quickfix operation in Android Studio and IntelliJ IDEA.

android/src/main/AndroidManifest.xml

Lines 301 to 305 in 322aee0

	<service
	android:name=".services.AccountManagerService"
	android:enabled="true"
	android:exported="true" >
	</service>

Is this what we discussed that a permission is not possible to set? Then I can ignore this warning?

[David-Development]

Hmm.. yes. This is what we discussed in nextcloud/Android-SingleSignOn#27. Even if we keep the permission.. any app that defines that permission will be also granted it. Or am I wrong here?

[tobiasKaminsky]

No, you are right. I just wanted to be sure.
Then I'll adjust lint-results and then merge 👍

[tobiasKaminsky]

(rebase will be a hell, so let us merge this instead, this time…)

[nextcloud-android-bot]

Lint

Type	Master	PR
Warnings	94	94
Errors

FindBugs (new)

Warning Type	Number
Bad practice Warnings	35
Correctness Warnings	164
Experimental Warnings	4
Internationalization Warnings	13
Malicious code vulnerability Warnings	9
Multithreaded correctness Warnings	9
Performance Warnings	157
Security Warnings	163
Dodgy code Warnings	135
Total	689

FindBugs (master)

Warning Type	Number
Bad practice Warnings	35
Correctness Warnings	166
Experimental Warnings	4
Internationalization Warnings	12
Malicious code vulnerability Warnings	9
Multithreaded correctness Warnings	9
Performance Warnings	156
Security Warnings	163
Dodgy code Warnings	135
Total	689

[tobiasKaminsky]

@AndyScherzinger are you fine with merging? :-D

[AndyScherzinger]

👍 perfectly fine, yes and also about not rebasing ;)