Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Iteration 1 for file detail & new sharing #2533

Merged
merged 27 commits into from
May 9, 2018
Merged

Conversation

AndyScherzinger
Copy link
Member

@AndyScherzinger AndyScherzinger commented Apr 30, 2018

WiP for #2485 and collab with @tobiasKaminsky

  • refactored the details screen to have 2 tabs for activities and sharing including swipe left/right for activities/sharing
  • add activities loading on a per file basis (possibly needs a server API change)
  • clarify "star use"
  • implement star / keep available offline (after discussion)
  • move overflow menu from top to Filename "row"
  • remove sharing icon from top menu
  • make header transparent, only back arrow visible (for preview-able files), non-preview-able files do not have any icon/preview, so that the first "row" is file name (and then we can show again a solid header).
  • add previews
  • add preview-able/non-preview-able toolbar handling
  • fix pull-to-refresh on activities tab
  • fix theming

Remarks:

  • add commenting and sharing option via separate PRs after this one is merged

What do you think @tobiasKaminsky @jancborchardt ?

Actual WiP UI-wise
device-2018-04-30-184640
device-2018-04-30-184658

@nextcloud nextcloud deleted a comment Apr 30, 2018
@nextcloud nextcloud deleted a comment Apr 30, 2018
@nextcloud nextcloud deleted a comment Apr 30, 2018
@nextcloud nextcloud deleted a comment Apr 30, 2018
@nextcloud nextcloud deleted a comment Apr 30, 2018
@nextcloud nextcloud deleted a comment Apr 30, 2018
@nextcloud nextcloud deleted a comment Apr 30, 2018
@nextcloud nextcloud deleted a comment Apr 30, 2018
@nextcloud nextcloud deleted a comment Apr 30, 2018
@AndyScherzinger
Copy link
Member Author

Added initial loading of activities (copied the code from the activities activity, so not file specific yet):
device-2018-04-30-191745

@nextcloud nextcloud deleted a comment Apr 30, 2018
@nextcloud nextcloud deleted a comment Apr 30, 2018
@nextcloud nextcloud deleted a comment Apr 30, 2018
@nextcloud nextcloud deleted a comment Apr 30, 2018
@nextcloud nextcloud deleted a comment Apr 30, 2018
@nextcloud nextcloud deleted a comment Apr 30, 2018
@nextcloud nextcloud deleted a comment Apr 30, 2018
@nextcloud nextcloud deleted a comment Apr 30, 2018
@nextcloud nextcloud deleted a comment Apr 30, 2018
@AndyScherzinger
Copy link
Member Author

@nickvergessen any hints on how to just load the activities of a given file? https://github.com/nextcloud/activity/blob/master/docs/endpoint-v2.md did give me any hints and the web UI is capable of doing so while I of course don't know if the web UI uses an API which allows for that and is also exposed for other clients.

@nextcloud nextcloud deleted a comment Apr 30, 2018
@nextcloud nextcloud deleted a comment Apr 30, 2018
@nextcloud nextcloud deleted a comment Apr 30, 2018
@nextcloud nextcloud deleted a comment Apr 30, 2018
@nextcloud nextcloud deleted a comment Apr 30, 2018
@nextcloud nextcloud deleted a comment Apr 30, 2018
@nextcloud nextcloud deleted a comment Apr 30, 2018
@nextcloud nextcloud deleted a comment Apr 30, 2018
@mario
Copy link
Contributor

mario commented May 9, 2018

👍

Approved with PullApprove

@AndyScherzinger AndyScherzinger merged commit ad064fd into master May 9, 2018
@AndyScherzinger AndyScherzinger deleted the fileDetail branch May 9, 2018 10:30
@AndyScherzinger AndyScherzinger added this to the Nextcloud App 3.2.0 milestone May 9, 2018
@AndyScherzinger
Copy link
Member Author

I'll soon start with Iteration 2 for follow up on this PR.

Things to be done

Happy for any collaboration @tobiasKaminsky @mario @ardevd

@AndyScherzinger AndyScherzinger changed the title Iteration 1 for File detail & new sharing Iteration 1 for file detail & new sharing May 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants