Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trashbin: do UI changes of async only if activity is still up and running #3365

Merged
merged 1 commit into from
Dec 14, 2018
Merged

Trashbin: do UI changes of async only if activity is still up and running #3365

merged 1 commit into from
Dec 14, 2018

Conversation

tobiasKaminsky
Copy link
Member

@tobiasKaminsky tobiasKaminsky commented Dec 13, 2018 •
edited
Loading

Fix #3035
Signed-off-by: tobiasKaminsky tobias@kaminsky.me

@tobiasKaminsky
do UI changes of async only if activity is still up and running
2e9428a 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
@nextcloud-android-bot
Copy link
Collaborator

Lint

TypemasterPR
Warnings8383
Errors00

FindBugs (new)

Warning TypeNumber
Bad practice Warnings35
Correctness Warnings159
Internationalization Warnings15
Malicious code vulnerability Warnings11
Multithreaded correctness Warnings9
Performance Warnings121
Security Warnings66
Dodgy code Warnings135
Total551

FindBugs (master)

Warning TypeNumber
Bad practice Warnings35
Correctness Warnings159
Internationalization Warnings15
Malicious code vulnerability Warnings11
Multithreaded correctness Warnings9
Performance Warnings121
Security Warnings66
Dodgy code Warnings135
Total551

@tobiasKaminsky tobiasKaminsky mentioned this pull request Dec 13, 2018
Closed
30 tasks
@AndyScherzinger
Copy link
Member

AndyScherzinger commented Dec 13, 2018 •
edited
Loading

👍

Approved with PullApprove

@mario
Copy link
Contributor

mario commented Dec 13, 2018 •
edited by AndyScherzinger
Loading

I'm sure we could use lifecycle observers here, but ... if it makes you happy :)

👍

Approved with PullApprove

@tobiasKaminsky
Copy link
Member Author

use lifecycle observers

Good idea, I'll have a look into this, but for a quick bugfix it is fine, I hope.

@tobiasKaminsky tobiasKaminsky merged commit 23b91eb into master Dec 14, 2018
@tobiasKaminsky tobiasKaminsky deleted the trashbinCheckIfActive branch December 14, 2018 06:46
@tobiasKaminsky
Copy link
Member Author

/backport to stable-3.4.x

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Dec 14, 2018
Merged
@backportbot-nextcloud
Copy link

backport to stable-3.4.x in #3369

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
3. to review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tobiasKaminsky @nextcloud-android-bot @AndyScherzinger @mario