Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implement team resource provider for shared files #1525

Merged
merged 2 commits into from
Mar 8, 2024

Conversation

juliushaertl
Copy link
Member

@juliushaertl juliushaertl commented Mar 7, 2024

Example screenshot from the team overview in contacts:

Screenshot 2024-03-07 at 17 16 48

Signed-off-by: Julius Härtl <jus@bitgrid.net>
Copy link
Member

@mejo- mejo- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look good to me. Only thing I don't understand is why CirclesManager could be null.

@juliushaertl
Copy link
Member Author

Ah that was because I started the class in the files_sharing app but thought it fits better in circles as then its just disabled if the app is.

Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliushaertl juliushaertl merged commit 1f26a43 into master Mar 8, 2024
20 checks passed
@juliushaertl juliushaertl deleted the feat/files-resource-list branch March 8, 2024 11:52
@juliushaertl juliushaertl mentioned this pull request Mar 8, 2024
28 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants