Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(editor): Add bottom border to menubar #1498

Merged
merged 1 commit into from
Sep 23, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/components/Collective.vue
Original file line number Diff line number Diff line change
Expand Up @@ -237,8 +237,7 @@ export default {

/* Format page title in Page.vue and Version.vue */
.page-title {
position: sticky;
top: 0;
position: relative;
z-index: 10022;
padding: 0 8px;
display: flex;
Expand Down
9 changes: 8 additions & 1 deletion src/components/Page/PageInfoBar.vue
Original file line number Diff line number Diff line change
Expand Up @@ -37,14 +37,17 @@ export default {

<style scoped lang="scss">
.text-menubar {
box-sizing: content-box !important;
--background-blur: blur(10px);
position: sticky;
top: 0;
z-index: 10021;
background-color: var(--color-main-background-translucent);
backdrop-filter: var(--background-blur);
height: var(--default-clickable-area);
padding: 3px 8px 3px 14px;
border-bottom: 1px solid var(--color-border);
padding-top: 3px;
padding-bottom: 3px;
display: flex;
flex-wrap: nowrap;
align-items: center;
Expand All @@ -61,6 +64,10 @@ export default {
opacity: .5;
}

.infobar-lastupdate {
padding-inline-start: 14px;
}

.infobar-seperator {
padding: 0px 12px;
opacity: .5;
Expand Down
6 changes: 6 additions & 0 deletions src/css/editor.scss
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,12 @@
--text-editor-max-width: 670px !important;
}

// TODO: can be removed once we only support Nextcloud 30+
.text-menubar {
border-bottom: 1px solid var(--color-border);
box-sizing: content-box !important;
}

.full-width-view {
// Required for search dialog to stick to the bottom
height: 100%;
Expand Down
Loading