Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Add return types of storage wrapper #1522

Merged
merged 2 commits into from
Oct 14, 2024
Merged

chore: Add return types of storage wrapper #1522

merged 2 commits into from
Oct 14, 2024

Conversation

juliushaertl
Copy link
Member

@juliushaertl juliushaertl commented Oct 9, 2024 •
edited
Loading

📝 Summary

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits
  • Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests
  • Documentation (README or documentation) has been updated or is not required

@juliushaertl
chore: Add return types of storage wrapper
d2770ae 
Signed-off-by: Julius Knorr <jus@bitgrid.net>
@juliushaertl
ci: Drop conflicting dev dependencies for behat
df190af 
Signed-off-by: Julius Knorr <jus@bitgrid.net>
@juliushaertl juliushaertl mentioned this pull request Oct 14, 2024
Closed
max-nextcloud
max-nextcloud approved these changes Oct 14, 2024
View reviewed changes
Copy link
Collaborator

@max-nextcloud max-nextcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yay! Thanks!

@max-nextcloud max-nextcloud merged commit e804ce0 into main Oct 14, 2024
53 checks passed
@max-nextcloud max-nextcloud deleted the chore/1518 branch October 14, 2024 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@max-nextcloud max-nextcloud max-nextcloud approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Collectives needs adjustment to server changes for 31
2 participants
@juliushaertl @max-nextcloud