-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Manage members in app #804
Conversation
@nextcloud/designers I'd appreciate feedback from you 😊 In particular on the icons used for admin/moderator/member levels and on the way the loading indicator icon is used. |
f268df7
to
207ac9a
Compare
51ef013
to
0993945
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From a design perspective, I'm sorry but I don't have any constructive feedback to share. It looks very neat and easy to use, congrats!! :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks very nice, code also looks good, just a few commments from testing:
- The search results are not keyboard accessible
- The scroll in the modal seems a bit odd with two scroll areas:
- Maybe we can hide the "Add users, groups or circles ..." heading if the search is not triggered, the placeholder hint to search to add groups seems enough and the members also don't have a heading in the default state
0993945
to
162bb32
Compare
@juliushaertl I would prefer to keep it. Talk behaves the same in the participants tab and I think its good to emphasize that you can search for new members to add. |
2203d38
to
42c047c
Compare
fdf69e1
to
7441dc0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, looks nice design-wise! :)
7441dc0
to
db0b0ce
Compare
Looking at the screencast it seems that people, circles and groups that are already in the collective are still listed in the sections to add members. I tried in talk and it seems to filter them out. I think that would be good. |
This is already fixed in the PR, but I didn't update the screencast |
a8c59f4
to
47cec45
Compare
Looks super nice! Only some minor points :)
|
Signed-off-by: Jonas <jonas@freesources.org>
Signed-off-by: Jonas <jonas@freesources.org>
* Refactor MemberPicker and MemberSearchResult, group search results inside MemberSearchResults. * Use `core/autocomplete/get` endpoint to get search results. * Fetch search results with empty search string at the beginning. Signed-off-by: Jonas <jonas@freesources.org>
Preparations for reusing MemberPicker for the membership management modal. Signed-off-by: Jonas <jonas@freesources.org>
Adds a modal for admin users that lists current members and allows to search for new ones. Current members have actions to get their level promoted/demoted and to get removed. Found new members can be added. Further refactoring of the MemberPicker is part of this commit. Signed-off-by: Jonas <jonas@freesources.org>
Signed-off-by: Jonas <jonas@freesources.org>
Signed-off-by: Jonas <jonas@freesources.org>
Signed-off-by: Jonas <jonas@freesources.org>
Signed-off-by: Jonas <jonas@freesources.org>
Signed-off-by: Jonas <jonas@freesources.org>
We have our own membership management in Collectives now. Also show collective action to leave a collective to admins. Fixes: #779 Signed-off-by: Jonas <jonas@freesources.org>
Signed-off-by: Jonas <jonas@freesources.org>
Signed-off-by: Jonas <jonas@freesources.org>
…Type Signed-off-by: Jonas <jonas@freesources.org>
Signed-off-by: Jonas <jonas@freesources.org>
Signed-off-by: Jonas <jonas@freesources.org>
Signed-off-by: Jonas <jonas@freesources.org>
Thanks @nimishavijay. I already changed the font color to |
47cec45
to
a78eb8a
Compare
In CI, our Cypress tests run against a single process PHP webserver. This causes problems with async circles events. Removing members from a circle is async. Disable the check for member being removed from UI for now. Signed-off-by: Jonas <jonas@freesources.org>
a78eb8a
to
0d4ec55
Compare
📝 Summary
This PR adds functionality to manage members for a collective inside the Collectives app. This removes our dependency on the Contacts app to do so.
It's possible to add and remove members and promote/demote their membership level.
🖼️ Screenshots
🖼️ Screencast
🚧 TODO
🏁 Checklist
npm run lint
/npm run stylelint
/composer run cs:check
)