Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pagelist): Grow link area in page list items to full height #810

Merged
merged 1 commit into from
Jul 28, 2023

Conversation

mejo-
Copy link
Member

@mejo- mejo- commented Jul 28, 2023

Fixes: #808

@mejo- mejo- added bug Something isn't working 3. to review labels Jul 28, 2023
@cypress
Copy link

cypress bot commented Jul 28, 2023

Passing run #981 ↗︎

0 75 0 0 Flakiness 0

Details:

fix(pagelist): Grow link area in page list items to full height
Project: Collectives Commit: 476a95d3a6
Status: Passed Duration: 04:00 💡
Started: Jul 28, 2023 3:04 PM Ended: Jul 28, 2023 3:08 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@max-nextcloud
Copy link
Collaborator

Looks good. Should we maybe also upstream this in nextcloud-vue or is it a collectives specific issue?

@mejo-
Copy link
Member Author

mejo- commented Jul 28, 2023

Should we maybe also upstream this in nextcloud-vue or is it a collectives specific issue?

It's specific to Collectives. We don't use a nextcloud-vue component here.

Fixes: #808

Signed-off-by: Jonas <jonas@freesources.org>
@mejo- mejo- force-pushed the fix/page_list_link_height branch from a68388b to 476a95d Compare July 28, 2023 14:31
@mejo- mejo- merged commit 2475b0f into main Jul 28, 2023
41 checks passed
@delete-merged-branch delete-merged-branch bot deleted the fix/page_list_link_height branch July 28, 2023 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Navigation pills are not clickable inside the upper or lower paddings
2 participants