small css changes #121
small css changes #121
Conversation
Codecov Report
@@ Coverage Diff @@
## master #121 +/- ##
=======================================
Coverage 71.85% 71.85%
=======================================
Files 32 32
Lines 828 828
=======================================
Hits 595 595
Misses 233 233 |
|
|
css/style.css
Outdated
| min-height: initial; | ||
| } | ||
|
|
||
| .stack h2 button, | ||
| .stack .stack-actions { | ||
| float: right; | ||
| margin: 3px 1px 3px 19px; |
There was a problem hiding this comment.
19px look a bit to stretched. That should be just the same as the margin on the top (inside the grey box).
There was a problem hiding this comment.
@juliushaertl it looks very poor...
There was a problem hiding this comment.
@juliushaertl we could move "description-icon" 1px to the right... for the symmetry
|
@artemanufrij Can you have a look? The delete button moves out of the container for long titles. Also the text should be vertically aligned to the center. When fixed can you squash those commits into one and add the signoff stuff? ;) |
|
@juliushaertl do you mean like this: |
css/style.css
Outdated
| } | ||
|
|
||
| .stack h2 span { | ||
| float: left; | ||
| width: 100%; | ||
| white-space: normal; |
There was a problem hiding this comment.
something wrong with indentation here
artemanufrij
force-pushed
the
icon-size-position
branch
2 times, most recently
from
289dbb0
to
b86f559
Compare
Signed-off-by: Artem Anufrij <artem.anufrij@live.de>
juliushaertl
force-pushed
the
icon-size-position
branch
2 times, most recently
from
dc373b9
to
96ab5e7
Compare
|
@artemanufrij I've squashed them for now. Btw. feel free to join #nextcloud-deck in IRC 😉 |
|
By the way, that Edit and Delete icon (presumably) should ideally be stacked vertically in the popover and have text next to it. See how we did it in the Mail app: nextcloud/mail#344 :) |
|
@jancborchardt Makes sense. @artemanufrij I think we already discussed that on irc. I'll open an issue for that. |
Signed-off-by: Artem Anufrij artem.anufrij@live.de
same margin and order:
