Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Toggle navibar on mobile #190

Merged
merged 2 commits into from
Jun 19, 2017
Merged

Toggle navibar on mobile #190

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
efb14bd
Toggle navigation bar on mobile and desktop devices
artemanufrij Jun 16, 2017
812ed56
Fix app-navigation-toggle height and small typo
juliushaertl Jun 19, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix app-navigation-toggle height and small typo 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
  • Loading branch information
@juliushaertl
juliushaertl committed Jun 19, 2017
commit 812ed56d9081c25721553e5ad903842a2585c60b
4 changes: 2 additions & 2 deletions css/style.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,8 +172,8 @@ button.button-inline:hover {
}

#app-navigation-toggle {
width: 45px;
height: 40px;
width: 44px;
height: 44px;
cursor: pointer;
opacity: 1;
display: inline-block !important;
Expand Down
4 changes: 2 additions & 2 deletions js/app/Run.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,9 +64,9 @@ app.run(function ($document, $rootScope, $transitions, BoardService) {

$('#app-navigation-toggle').click(function(){
if($(window).width() > 768) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this if, since the toggle should always be visible - then you won't need !important in CSS

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it for different behavior. on mobile devices app-content will be moved to the right. on desktop app-navigation will be hide.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does it even work, @artemanufrij ? Look at the next line toggle('hidde') is not correct 😉

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it works fine....

$('#app-navigation').toggle('hidde');
$('#app-navigation').toggle('hidden');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 that's what I was talking about :)

} else {
if(snapper.state().state == 'left'){
if(snapper.state().state === 'left'){
snapper.close();
} else {
snapper.open('left');
Expand Down