polish sidebar #215
polish sidebar #215
Conversation
Signed-off-by: Artem Anufrij <artem.anufrij@live.de>
|
Current design: |
Codecov Report
@@ Coverage Diff @@
## master #215 +/- ##
=======================================
Coverage 76.56% 76.56%
=======================================
Files 33 33
Lines 973 973
=======================================
Hits 745 745
Misses 228 228 |
Signed-off-by: Artem Anufrij <artem.anufrij@live.de>
Signed-off-by: Artem Anufrij <artem.anufrij@live.de>
Signed-off-by: Artem Anufrij <artem.anufrij@live.de>
Signed-off-by: Artem Anufrij <artem.anufrij@live.de>
|
last version: |
Signed-off-by: Artem Anufrij <artem.anufrij@live.de>
templates/part.card.php
Outdated
| @@ -28,54 +28,45 @@ | |||
| <?php p($l->t('by')); ?> | |||
| <span>{{ cardservice.getCurrent().owner.displayname }}</span> | |||
| </div> | |||
|
|
|||
| <h3 style="padding-top: 0px; margin-top: 0px;"> | |||
There was a problem hiding this comment.
No inline styles please ;)
| <?php p($l->t('Description')); ?> | ||
| <a href="https://github.com/nextcloud/deck/wiki/Markdown-Help" target="_blank" class="icon-help" title="<?php p($l->t('Formatting help')); ?>"></a> | ||
| <span class="save-indicator"><?php p($l->t('Saved')); ?></span> | ||
| <div> |
There was a problem hiding this comment.
What is the need of two wrapping divs here? h3 is already a block element that could be used.
There was a problem hiding this comment.
But we can just apply the flex styles to #card-meta h3 or am I missing something?
There was a problem hiding this comment.
display: flex changes some margin/padding behavior. It looks some different in compare to standard h3
| </div> | ||
|
|
||
|
|
| @@ -926,6 +954,9 @@ button.button-inline:hover { | |||
| margin-bottom: 0; | |||
| } | |||
|
|
|||
| .tabsContainer { | |||
| margin-top: 15px; | |||
| } | |||
css/style.css
Outdated
| } | ||
|
|
||
| #card-meta .duedate .icon:hover { | ||
| opacity: 0.7; |
There was a problem hiding this comment.
Not really needed, since the hover effect is done by the icon-delete class.
There was a problem hiding this comment.
There is just the delete button 😉
https://github.com/nextcloud/deck/pull/215/files#diff-a175750cce89c445e0a34d25823924c2R56
There was a problem hiding this comment.
but it doesn't change opacity. only color. for buttons we use always a different opacity on mouse over.
css/style.css
Outdated
| } | ||
|
|
||
| #card-meta .duedate .icon { | ||
| opacity: 0.3; |
There was a problem hiding this comment.
I would go to 0.5 opacity, since it should be default for all icons on nextcloud: nextcloud/server#5157
|
@juliushaertl |
Signed-off-by: Artem Anufrij artem.anufrij@live.de