add card in upcoming cards view #2332
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jakob Röhrl <jakob.roehrl@web.de>
Signed-off-by: Jakob Röhrl <jakob.roehrl@web.de>
Signed-off-by: Jakob Röhrl <jakob.roehrl@web.de>
src/components/Controls.vue
Outdated
| async addCard() { | ||
| try { | ||
| const today = new Date() | ||
| today.setHours(23, 59, 59, 999) |
There was a problem hiding this comment.
I'm not sure about this, having a card due at 23:59 is probably not the best attempt.
How about adding a date picker and setting a default due date for in an hour there?
There was a problem hiding this comment.
Most of Todo Tools use Today as default.
Regarding #2231 (comment) Today is the current date and 23:59
There was a problem hiding this comment.
In #1157 we are discussing the different purpose of a due date at a specific time/timezone and a due date at a day.
Regarding Desk and the current issues 23:59 seems to be a quick win for me, that can be imoroved later.
jakobroehrl
force-pushed
the
enh/addCardInUpcomingCardsView
branch
from
aae966c
to
cab9f5b
Compare
Signed-off-by: Jakob Röhrl <jakob.roehrl@web.de>
jakobroehrl
force-pushed
the
enh/addCardInUpcomingCardsView
branch
from
cab9f5b
to
45f811f
Compare
|
Very nice! :) Some design feedback:
|
|
closing in favour of #2854 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jakob Röhrl jakob.roehrl@web.de
Ideas