Reduce duplicate queries when fetching user boards an permissions #3161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliushaertl
force-pushed
the
bugfix/sql-queries
branch
from
af1e0b8
to
5a566c0
Compare
juliushaertl
force-pushed
the
bugfix/sql-queries
branch
from
5a566c0
to
cb716ee
Compare
nickvergessen
approved these changes
Jul 2, 2021
blizzz
reviewed
Jul 2, 2021
lib/Db/BoardMapper.php
Outdated
| $groupBoards = $this->findAllByGroups($userId, $groups,null, null, $since, $includeArchived); | ||
| $circleBoards = $this->findAllByCircles($userId, null, null, $since, $includeArchived); | ||
| return array_unique(array_merge($userBoards, $groupBoards, $circleBoards)); | ||
| if (!array_key_exists($userId, $this->userBoardCache)) { |
There was a problem hiding this comment.
isset() is said to be faster, but there is a small difference –https://www.php.net/manual/en/function.array-key-exists.php example #2. For consideration.
blizzz
reviewed
Jul 2, 2021
lib/Db/BoardMapper.php
Outdated
| @@ -39,6 +39,8 @@ class BoardMapper extends DeckMapper implements IPermissionMapper { | |||
|
|
|||
| private $circlesEnabled; | |||
|
|
|||
| private $userBoardCache = []; | |||
There was a problem hiding this comment.
could be also CappedMemoryCache to avoid overflow.
blizzz
reviewed
Jul 2, 2021
lib/Service/PermissionService.php
Outdated
| return $board && $userId === $board->getOwner(); | ||
| } catch (DoesNotExistException | MultipleObjectsReturnedException $e) { | ||
| } | ||
| return false; | ||
| } | ||
|
|
||
| private function getBoard($boardId): Board { | ||
| if (!array_key_exists($boardId, $this->boardCache)) { |
juliushaertl
force-pushed
the
bugfix/sql-queries
branch
from
80d2580
to
b4cee7f
Compare
|
/backport to stable22 |
|
/backport to stable1.4 |
|
Looking into the tests |
nickvergessen
approved these changes
Jul 5, 2021
Signed-off-by: Julius Härtl <jus@bitgrid.net>
juliushaertl
force-pushed
the
bugfix/sql-queries
branch
from
b4cee7f
to
ae2aa8c
Compare
This was referenced Jul 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First step to reduce the amounts of queries that happened during collecting incoming shares when setting up the filesystem for users.
Already gives quite some improvement in test setup with 1 shared board having 3 cards with a handful of attachments on each:
https://blackfire.io/profiles/compare/67ec272e-9530-491b-afb2-0fb2c9b06f59/graph