live updates 🎉 #4273
live updates 🎉 #4273
Conversation
|
@alangecker You are just sooooo amazing thanks a lot for your incredible job on #3876! Just absolutely exited to see your achievement here also! And as promised as soon as you're near to release I will reward your job again. Words are just out of my mind, so I will keep it simple : THANK YOU! |
alangecker
force-pushed
the
live-updates
branch
2 times, most recently
from
a529c57
to
0b28240
Compare
|
I guess it is now also ready for a review 🙂 |
|
@juliushaertl could you let run the CI to see what need to be done there? |
alangecker
force-pushed
the
live-updates
branch
from
bb78007
to
587a5cf
Compare
|
@alangecker I invited you as a contributor to the repo so follow up pushes should not require approval any longer. |
|
@juliushaertl ui, thanks! that helps a lot and probably also reduces your work load 🙂 |
alangecker
force-pushed
the
live-updates
branch
from
587a5cf
to
b040c22
Compare
|
The functionality is there and all the checks in the CI are green. I mean, it's time for a reward! I really hope that either @juliushaertl or @marcelklehr will have the time to review it soon, but for myself it's time to act 😄 Again many thanks @alangecker and wish you an happy new year! |
|
Hi everyone, I know we all have many things on the plate, but we are eagerly waiting on this MR for our staff. How do you see the next steps @juliushaertl and @marcelklehr? Wish you all the best |
|
I've blocked some time to review and test this next week. |
|
Wow, I totally missed this in my inbox so far. Sorry! |
| const currentBoardId = store.state.currentBoard?.id | ||
| if (body.boardId !== currentBoardId) return | ||
|
|
||
| store.dispatch('loadStacks', currentBoardId) |
There was a problem hiding this comment.
Without having checked myself: Would it be possible to only update the changed card?
There was a problem hiding this comment.
This would be definitely nice if we could just fetch the one updated card
|
Code looks good IMHO. Will try to find time to test next week. |
|
Kindly reminder 😸 |
|
Amazing!!! 🍾 If @alangecker fixes the very last details in the next few days, when do you plan to release the public version for Nextcloud users? If I'm not mistaken, #3876 is still not available with the last version 1.8.3, is it? |
|
Since this is a larger feature it will become part of the next minor release 1.9 which is scheduled together with Nextcloud 26. Backports to older versions only happen for bug fixes unfortunately. |
|
thanks to all of you ♥ there are somehow now some tests failing. |
|
I'll check the psalm errors as they also happen on the main branch. I've noticed a small bug when trying to share a board, the fix was straight forward but maybe you can put that into your branch directly so we have the changes together: 49d424e |
|
psalm checks should also pass now after a rebase :) |
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
Signed-off-by: chandi Langecker <git@chandi.it>
Signed-off-by: chandi Langecker <git@chandi.it>
…end them Signed-off-by: chandi Langecker <git@chandi.it>
Signed-off-by: chandi Langecker <git@chandi.it>
Signed-off-by: chandi Langecker <git@chandi.it>
… required for event emitting Signed-off-by: chandi Langecker <git@chandi.it>
juliushaertl
force-pushed
the
live-updates
branch
from
5fb0743
to
b4eece8
Compare
|
I took the liberty to rebase and push so we can get this in for the first pre-release for Nextcloud 26. |
|
Let's get this in 🚀 |
|
🎉🎉🎉🎉🎉 |
Summary
Checklist