Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Dark Theme #7255

Open
jahway603 opened this issue Oct 1, 2024 · 6 comments
Open

Add Dark Theme #7255

jahway603 opened this issue Oct 1, 2024 · 6 comments
Assignees
Labels
0. Needs triage enhancement enhancement of a already implemented feature/code

Comments

@jahway603
Copy link

How to use GitHub

  • Please use the 👍 reaction to show that you are interested into the same feature.
  • Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
  • Subscribe to receive notifications on status change and new comments.

Feature request

Which Nextcloud Version are you currently using: Nextcloud desktop client 3.14.1

Is your feature request related to a problem? Please describe.
The application is very bright and causes eye strain & it does not contain an option to switch to a "Dark Theme".

Describe the solution you'd like
Implement an option to switch to a "Dark Theme".

Describe alternatives you've considered
Squinting my eyes because of how bright it is.

Additional context
N/A

@jahway603 jahway603 added 0. Needs triage enhancement enhancement of a already implemented feature/code labels Oct 1, 2024
@camilasan camilasan self-assigned this Oct 2, 2024
@Toorero
Copy link

Toorero commented Oct 2, 2024

Image
Image

@Toorero
Copy link

Toorero commented Oct 2, 2024

Already working for me. You just have to set a dark QT theme I guess. I'm currently using Flatremix together with the QGtkStyle on Gnome.

@jahway603
Copy link
Author

@Toorero Thank you for your response & the helpful thumbs down, but the inherited QT dark theme is not working for me.

I'm using Artix with SwayWM & I do have a QT dark theme already setup using qt5ct which I do see being applied correctly to other QT applications, such as qt5ct itself and caja.

fastfetch shows the following for QT set themes:

  • Theme: Windows [Qt]
  • Icons: Vimix-Doder-dark [Qt]

@RokeJulianLockhart
Copy link

#7255 (comment)

@jahway603, your title is that of an FR. If the included theme isn't functioning, then that's a bug report, not a feature request.

@Toorero
Copy link

Toorero commented Oct 7, 2024

fastfetch shows the following for QT set themes:

* Theme: Windows [Qt]

* Icons: Vimix-Doder-dark [Qt]

For me, it shows:

  • Theme: Flat-Remix-GTK-Blue-Light-Solid [GTK2/3/4]
  • Icons: Flat-Remix-Blue-Dark [GTK2/3/4]

After digging through the README.md it seems the project is using Qt6 since version 3.14 rather than Qt5 as I proclaimed. Maybe your setup for Qt6 is insufficient, and your theme is only being applied to Qt5 applications? Also think I have not setup QGTKStyle for Qt6 (yet) so there is that. I'm unsure how dark-theme switching is implemented using Qt only, since I rely on Gnome to do the magic somehow. Are you just setting a fixed Qt theme, and it applies to other application (using Qt6) but not Nextcloud, so Nextcloud falls back to the default (light) theme?

@Toorero
Copy link

Toorero commented Oct 7, 2024

@Toorero Thank you for your response & the helpful thumbs down

You're welcome. In my opinion, it's not the job of every individual application to offer a light/dark-theme switch as your feature-request implies, so there is that.

Also, as the issue discussion and my example shows. There are external ways to theme Nextcloud if you are displeased with the default light theme it provides, and everything seems to boil down to either a misconfigured system or a theme somehow unsupported by Nextcloud.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0. Needs triage enhancement enhancement of a already implemented feature/code
Projects
None yet
Development

No branches or pull requests

4 participants