Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ask server to recalculate checksum(hash) #4100

Merged
merged 5 commits into from
Jan 11, 2022
Merged

Ask server to recalculate checksum(hash) #4100

merged 5 commits into from
Jan 11, 2022

Conversation

allexzander
Copy link
Contributor

@allexzander allexzander commented Dec 20, 2021 •
edited
Loading

As nextcloud/server#27378 is already merged and is going to be released in NC24.

This will fix #3409

@allexzander allexzander changed the title Feature/ask server to recalc checksum Ask server to recalculate checksum(hash) Dec 20, 2021
@szaimen
Copy link
Contributor

szaimen commented Dec 20, 2021 •
edited
Loading

As nextcloud/server#27378 is already merged and is going to be released in NC24.

No it is not yet. See nextcloud/server#29510

mgallien
mgallien reviewed Dec 22, 2021
View reviewed changes
Copy link
Collaborator

@mgallien mgallien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice to have automated tests !
see my comments

src/common/checksums.h Show resolved Hide resolved
src/common/checksums.h Outdated Show resolved Hide resolved
src/libsync/networkjobs.h Outdated Show resolved Hide resolved
src/common/checksums.h Outdated Show resolved Hide resolved
@allexzander allexzander force-pushed the feature/ask-server-to-recalc-checksum branch 3 times, most recently from addd911 to fa6227d Compare December 23, 2021 10:39
@allexzander
Copy link
Contributor Author

As nextcloud/server#27378 is already merged and is going to be released in NC24.

No it is not yet. See nextcloud/server#29510

@szaimen Can I still assume this feature to be available in 24?

@szaimen
Copy link
Contributor

szaimen commented Dec 23, 2021

@szaimen Can I still assume this feature to be available in 24?

I don't know. Feel free to ask this in the files or engineering chat :)

@allexzander
Copy link
Contributor Author

nice to have automated tests ! see my comments

@mgallien Thank you. Fixed.

@allexzander allexzander force-pushed the feature/ask-server-to-recalc-checksum branch from 27848cb to 5b9a5ce Compare December 27, 2021 08:27
@allexzander
Copy link
Contributor Author

@mgallien Any comments?

@allexzander allexzander force-pushed the feature/ask-server-to-recalc-checksum branch from 6632c74 to 1b33852 Compare January 11, 2022 12:42
@allexzander
Copy link
Contributor Author

/rebase

@nextcloud-command nextcloud-command force-pushed the feature/ask-server-to-recalc-checksum branch from 1b33852 to 4ced494 Compare January 11, 2022 12:45
@allexzander
Copy link
Contributor Author

/rebase

@allexzander
Ask server to recalculate checksum on validatin failure.
b7be10f 
Signed-off-by: alex-z <blackslayer4@gmail.com>
@allexzander
Fix typo in usernamePrefillServerVersionMinSupportedMajor.
6f5f3e7 
Signed-off-by: alex-z <blackslayer4@gmail.com>
@allexzander
Checksum validator unit tests.
5b0e2d8 
Signed-off-by: alex-z <blackslayer4@gmail.com>
@allexzander
Checksum validation PropagateDownload unit tests.
190d278 
Signed-off-by: alex-z <blackslayer4@gmail.com>
@allexzander
Refactor DeleteJob and DeleteApiJob to use SimpleFileJob.
225753a 
Signed-off-by: alex-z <blackslayer4@gmail.com>
@nextcloud-command nextcloud-command force-pushed the feature/ask-server-to-recalc-checksum branch from 4ced494 to 225753a Compare January 11, 2022 13:37
@allexzander allexzander merged commit 2e0ba82 into master Jan 11, 2022
@allexzander allexzander deleted the feature/ask-server-to-recalc-checksum branch January 11, 2022 13:40
@allexzander
Copy link
Contributor Author

this can wait till next major release

@sonarcloud
Copy link

sonarcloud bot commented Jan 11, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 18 Code Smells

83.3% 83.3% Coverage
0.0% 0.0% Duplication

@nextcloud-desktop-bot
Copy link

AppImage file: Nextcloud-PR-4100-225753a8c0c45a3c2866f5b6a0cfa7af1933f498-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@mgallien mgallien added this to the 3.5.0 milestone Jan 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgallien mgallien mgallien approved these changes

@claucambra claucambra claucambra approved these changes

@camilasan camilasan Awaiting requested review from camilasan

Assignees
No one assigned
Labels
2. to review
Projects
None yet
Milestone
3.5.0
5 participants
@allexzander @szaimen @nextcloud-desktop-bot @mgallien @claucambra