Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nmc/add new unit test files #5808

Closed

Conversation

AnkurBavisa
Copy link

Added new Unit Test files(which are not present in Nextcloud repo) with template, dependent header files and some member access dependency.
Later we will add testcase for NMC changes & nextcloud can also add required test cases.

@mgallien
Copy link
Collaborator

@AnkurBavisa could you please rebase this branch on top of the master branch that is the target of the PR ?
there are currently duplicated commits that are also present in the target branch ?

Copy link
Collaborator

@mgallien mgallien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we were unable to compile the branch due to errors with include of headers

test/testusermodel.cpp Outdated Show resolved Hide resolved
test/testwindow.cpp Outdated Show resolved Hide resolved
#include <QtTest>

#include "account.h"
#define private public
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if I remember correctly, on windows public or private symbols in a shared library are encoded with different symbols
is this really needed and working ?

Copy link
Author

@AnkurBavisa AnkurBavisa Jul 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we have to verify and access private member of code, so without update its accessibility in core code, we have handle it here and its working fine

@AnkurBavisa
Copy link
Author

@AnkurBavisa could you please rebase this branch on top of the master branch that is the target of the PR ? there are currently duplicated commits that are also present in the target branch ?

Okay, sure

Copy link
Member

@camilasan camilasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, remove the commit: 090eae3

@AnkurBavisa AnkurBavisa force-pushed the nmc/add_new_unit_test_files branch 2 times, most recently from 409ec86 to 126bd57 Compare July 4, 2023 09:04
@AnkurBavisa AnkurBavisa force-pushed the nmc/add_new_unit_test_files branch 3 times, most recently from 6cefe7e to b7d780f Compare July 4, 2023 11:39
Signed-off-by: Ankur Bavisa <Ankur.Bavisa@t-systems.com>
@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-5808-3d58d4fb374186562b239fcc37f2b99060b512de-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

Copy link
Member

@camilasan camilasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use rebase to update it to master commits, not merge:
git checkout master
git pull origin master --rebase
git checkout add_new_unit_test_files
git rebase master

@AnkurBavisa
Copy link
Author

AnkurBavisa commented Jul 4, 2023

Use rebase to update it to master commits, not merge: git checkout master git pull origin master --rebase git checkout add_new_unit_test_files git rebase master

Yes, we tried same, but its still showing, locally showing only 2 commits while rebasing but in PR again its showing 25+ commits.

@AnkurBavisa
Copy link
Author

Closing this PR due to too many unresolved commits, raise new PR for the same.
New PR: #5867

@AnkurBavisa AnkurBavisa closed this Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants