Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly check for webdav or dav path in provided host url for cmd.cpp #7286

Merged
merged 3 commits into from
Oct 11, 2024
Merged

Properly check for webdav or dav path in provided host url for cmd.cpp #7286

merged 3 commits into from
Oct 11, 2024

Conversation

claucambra
Copy link
Collaborator

@claucambra claucambra commented Oct 9, 2024 •
edited
Loading

Fixes #7233

Close #7233

@claucambra claucambra self-assigned this Oct 9, 2024
@claucambra claucambra mentioned this pull request Oct 9, 2024
Closed
8 tasks
@mgallien
Copy link
Collaborator

mgallien commented Oct 9, 2024

@claucambra is it a fix for #7233 ?
if yes, please add a Close https://github.com/nextcloud/desktop/issues/7233 comment to get the link and automated close of the issue on merge

@claucambra
Copy link
Collaborator Author

@claucambra is it a fix for #7233 ? if yes, please add a Close https://github.com/nextcloud/desktop/issues/7233 comment to get the link and automated close of the issue on merge

Doesn't "Fixes XYZ" already do this?

I added Close https://github.com/nextcloud/desktop/issues/7233 just in case

@claucambra
Remove unused <random> import in cmd.cpp
a7c9282 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
@claucambra
Encourage use of https in error message for cmd.cpp
fc2fb02 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
@claucambra
Properly check for webdav or dav path in provided host url for cmd.cpp
e79e86f 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-7286-e79e86fde01bb609856902f9175ef43260c9fce7-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 11, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
C Maintainability Rating on New Code (required ≥ A)
3 New Code Smells (required ≤ 0)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@claucambra claucambra merged commit 7b826d5 into master Oct 11, 2024
10 of 15 checks passed
@claucambra claucambra deleted the bugfix/cmd-hosturl-parse branch October 11, 2024 06:46
@claucambra
Copy link
Collaborator Author

/backport to stable-3.14

@backportbot backportbot bot mentioned this pull request Oct 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgallien mgallien mgallien approved these changes

@camilasan camilasan Awaiting requested review from camilasan

Assignees

@claucambra claucambra

Labels
feature: 🔳 nextcloudcmd
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: nextcloudcmd prejudiced against users named david
3 participants
@claucambra @mgallien @nextcloud-desktop-bot