Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable-3.14] Fix authentication issues for macOS File Provider Extension #7302

Merged
merged 7 commits into from
Oct 11, 2024
Merged

[stable-3.14] Fix authentication issues for macOS File Provider Extension #7302

merged 7 commits into from
Oct 11, 2024

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented Oct 11, 2024

Backport of PR #7240

@claucambra @backportbot
Try to authenticate new account details before setting them
e7e958e 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
@claucambra @backportbot
Retry authentication if connection timed out
35073e6 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
@claucambra @backportbot
Wait for task to complete synchronously after setting up domain accou…
47bb200 
…nt rather than wrapping everything in task

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
@claucambra @backportbot
Fetch user profile (and user ID) when setting up domain account
94b84a5 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
@claucambra @backportbot
Properly provide both user-provided username AND backing user ID to F…
5b472a2 
…ile Provider Extension

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
@claucambra @backportbot
Handle userId correctly in File Provider Extension client interface
49f7b06 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
@claucambra @backportbot
Stop fetching user profile details now that is not necessary in file …
5eceb72 
…provider extension

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
@backportbot backportbot bot added this to the 3.14.2 milestone Oct 11, 2024
@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-7302-5eceb725c8c2fb613042e5a46fcd99846c25e257-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 11, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@claucambra claucambra merged commit e05ab41 into stable-3.14 Oct 11, 2024
12 of 15 checks passed
@claucambra claucambra deleted the backport/7240/stable-3.14 branch October 11, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@claucambra claucambra claucambra approved these changes

@mgallien mgallien Awaiting requested review from mgallien

Assignees

@claucambra claucambra

Labels
3. to review feature: 💽 virtual filesystem os: 🍎 macOS
Projects
None yet
Milestone
3.14.2
Development

Successfully merging this pull request may close these issues.
2 participants
@nextcloud-desktop-bot @claucambra