This repository has been archived by the owner on May 21, 2024. It is now read-only.
W2G2 Integration #62
Closed
W2G2 Integration #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Needed to block right click menu when a file is locked!
NastuzziSamy
suggested changes
Apr 14, 2019
js/files.js
Outdated
| currentFile.find('.filename .nametext').click(); | ||
|
|
||
| // W2G2 Integration | ||
| if ($(currentFile).find(".statelock").length == 0) { |
There was a problem hiding this comment.
You made such a big refractor, I think it would be better to only check if the file is locked and if it is, just return null so the menu does not even process :)
There was a problem hiding this comment.
I think the spaces made the big refactor... VSCode auto beautifier...
There was a problem hiding this comment.
@dnviti could you update the pull request or make a new pull request without the auto beautifier? :)
|
But thank you for the PR, nice point in handling this haha :) |
dnviti
commented
Aug 22, 2019
Same result, take a look at this |
|
cc @juliushaertl on this one regarding the files side since it might conflict with other stuff? |
This was referenced Aug 12, 2022
This was referenced Aug 24, 2022
This was referenced Sep 6, 2022
This was referenced Sep 20, 2022
This was referenced May 3, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed to block right click menu when a file is locked!