Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Apply class to wizard page title (was a typo) and correctly navigate to page whats-new page #1185

Merged
merged 2 commits into from
Apr 23, 2024
Merged

fix: Apply class to wizard page title (was a typo) and correctly navigate to page whats-new page #1185

merged 2 commits into from
Apr 23, 2024

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Apr 22, 2024

image

heading sizes see #1184

@susnux
fix: Apply class to wizard page title (was a typo) and correctly navi…
94809d2 
…gate to page whats-new page

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux requested review from Pytal and szaimen April 22, 2024 23:08
@susnux
Copy link
Contributor Author

susnux commented Apr 22, 2024

/backport to stable29

@susnux susnux mentioned this pull request Apr 22, 2024
Closed
szaimen
szaimen approved these changes Apr 23, 2024
View reviewed changes
Copy link
Collaborator

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works :)

@szaimen
Copy link
Collaborator

szaimen commented Apr 23, 2024

/compile

@szaimen szaimen enabled auto-merge April 23, 2024 08:01
@nextcloud-command
chore(assets): Recompile assets
6e49aba 
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@szaimen szaimen merged commit cfb94ba into master Apr 23, 2024
39 checks passed
@szaimen szaimen deleted the fix/regressions branch April 23, 2024 09:04
@backportbot backportbot bot mentioned this pull request Apr 23, 2024
Merged
2 tasks
@github-actions GitHub Actions
Copy link

github-actions bot commented May 7, 2024

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

@blizzz blizzz mentioned this pull request Jul 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szaimen szaimen szaimen approved these changes

@sorbaugh sorbaugh sorbaugh approved these changes

@Pytal Pytal Awaiting requested review from Pytal

Assignees
No one assigned
Labels
3. to review bug feedback-requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Regressions in firstrunwizard
4 participants
@susnux @szaimen @sorbaugh @nextcloud-command