Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Make "share on" entries same width #1338

Merged
merged 2 commits into from
Aug 29, 2024
Merged

fix: Make "share on" entries same width #1338

merged 2 commits into from
Aug 29, 2024

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Aug 28, 2024

before after
Screenshot 2024-08-28 at 18-53-32 Personal info - Personal settings - Nextcloud Screenshot 2024-08-28 at 18-58-54 Personal info - Personal settings - Nextcloud

@susnux susnux added this to the Nextcloud 31 milestone Aug 28, 2024
@susnux susnux requested review from Pytal and szaimen August 28, 2024 17:00
@susnux
Copy link
Contributor Author

susnux commented Aug 28, 2024

/backport to stable30

szaimen
szaimen approved these changes Aug 29, 2024
View reviewed changes
Copy link
Collaborator

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@szaimen
Copy link
Collaborator

szaimen commented Aug 29, 2024 •
edited
Loading

However noticed something else (height is not the same):
image
Shall I open a new issue?

@susnux
fix: Make "share on" entries same width
6a0a895 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
chore: Compile assets
9d2e7dd 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux enabled auto-merge August 29, 2024 12:53
@susnux
Copy link
Contributor Author

susnux commented Aug 29, 2024

Shall I open a new issue?

yes I would say not directly related to this :)

@susnux susnux merged commit c2cdd9d into master Aug 29, 2024
40 checks passed
@susnux susnux deleted the fix/share-card-width branch August 29, 2024 13:09
@backportbot backportbot bot mentioned this pull request Aug 29, 2024
Open
2 tasks
@szaimen szaimen mentioned this pull request Aug 29, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szaimen szaimen szaimen approved these changes

@Pytal Pytal Awaiting requested review from Pytal

Assignees
No one assigned
Labels
3. to review design
Projects
None yet
Milestone
Nextcloud 31
Development

Successfully merging this pull request may close these issues.
2 participants
@susnux @szaimen