Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust design based on Design Review #1344

Merged
merged 3 commits into from
Sep 20, 2022
Merged

Adjust design based on Design Review #1344

merged 3 commits into from
Sep 20, 2022

Conversation

Chartman123
Copy link
Collaborator

@Chartman123 Chartman123 commented Sep 15, 2022 •
edited
Loading

  • Change Icons for results and links based on a decision in a design review
  • Switch public and internal links in Sidebar
  • Left align questions and header in create view

Signed-off-by: Christian Hartmann chris-hartmann@gmx.de

@Chartman123 Chartman123 added 2. developing Work in progress design Related to the design labels Sep 15, 2022
@Chartman123 Chartman123 added this to the 3.0 milestone Sep 15, 2022
@Chartman123 Chartman123 mentioned this pull request Sep 16, 2022
Closed
18 tasks
jotoeri
jotoeri reviewed Sep 20, 2022
View reviewed changes
src/views/Create.vue Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Sep 20, 2022 •
edited
Loading

Codecov Report

Merging #1344 (9f92b3f) into master (e556d32) will decrease coverage by 0.01%.
The diff coverage is n/a.

❗ Current head 9f92b3f differs from pull request most recent head 48afa04. Consider uploading reports for the commit 48afa04 to get more accurate results

Additional details and impacted files 
@@             Coverage Diff              @@
##             master    #1344      +/-   ##
============================================
- Coverage     36.84%   36.83%   -0.02%     
+ Complexity      512      507       -5     
============================================
  Files            48       47       -1     
  Lines          1973     1960      -13     
============================================
- Hits            727      722       -5     
+ Misses         1246     1238       -8

@Chartman123 Chartman123 force-pushed the fix/adjustments_designreview branch 2 times, most recently from 294d414 to fd85d01 Compare September 20, 2022 16:29
@Chartman123
Change Icons based on Design Review
9fefa63 
Signed-off-by: Christian Hartmann <chris-hartmann@gmx.de>
@Chartman123
Switch public and internal links in Sidebar
fcc6dbc 
Signed-off-by: Christian Hartmann <chris-hartmann@gmx.de>
@Chartman123
Left align questions and header in create view
48afa04 
Signed-off-by: Christian Hartmann <chris-hartmann@gmx.de>
@Chartman123 Chartman123 marked this pull request as ready for review September 20, 2022 21:29
@Chartman123 Chartman123 added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Sep 20, 2022
@jotoeri jotoeri merged commit 382fc27 into master Sep 20, 2022
@jotoeri jotoeri deleted the fix/adjustments_designreview branch September 20, 2022 21:42
@jotoeri jotoeri added the bug Something isn't working label Sep 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jotoeri jotoeri jotoeri approved these changes

Assignees
No one assigned
Labels
3. to review Waiting for reviews bug Something isn't working design Related to the design
Projects
None yet
Milestone
3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Chartman123 @jotoeri