Add technical identifiers for questions #1553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susnux
added
enhancement
susnux
force-pushed
the
feat/technical-names
branch
from
34df0a7
to
7a15be9
Compare
susnux
force-pushed
the
feat/technical-names
branch
2 times, most recently
from
2985c69
to
686aeff
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1553 +/- ##
============================================
- Coverage 40.16% 40.03% -0.14%
- Complexity 560 562 +2
============================================
Files 54 55 +1
Lines 2365 2378 +13
============================================
+ Hits 950 952 +2
- Misses 1415 1426 +11 |
susnux
force-pushed
the
feat/technical-names
branch
from
686aeff
to
3f0f96d
Compare
Chartman123
approved these changes
Jun 24, 2023
susnux
force-pushed
the
feat/technical-names
branch
from
3f0f96d
to
d474b1d
Compare
|
@Chartman123 Shure, done. The second commit was just for review purpose to see why I changed it :) |
|
@susnux Please also add the new prop to the API docs :) |
Technical identifiers allow to map form questions to custom data. On the frontend those identifiers are implemented as `name` props on the form elements. The name attribute for technical identifier should be mapped to all options so a `fieldset` is introduced around radio / checkbox buttons. Added required aria label for `fieldset` (labeled by the question title). Signed-off-by: Ferdinand Thiessen <rpm@fthiessen.de>
susnux
force-pushed
the
feat/technical-names
branch
from
d474b1d
to
46dfde2
Compare
Done ✔️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Technical identifiers allow to map form questions to custom data.
On the frontend those identifiers are implemented as
nameprops on the form elements.Screenshots
Name input:
Other notes
The name attribute for technical identifier should be mapped to all options so a
fieldsetis introduced around radio / checkbox buttons.Added required aria label for
fieldset(labeled by the question title).