-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix submission of other answers #1760
Conversation
Signed-off-by: Christian Hartmann <chris-hartmann@gmx.de>
@AIlkiv Perhaps you could also have another look at this. Current main is broken if you allow custom answers and also the validation on the server side. Statistics are also not counted correctly. @susnux This is my first attempt to fix the problem that I told you about. I'm currently not really sure where this is coming from, might be my change that fixed the output for XML in #1705 |
@@ -62,7 +62,7 @@ | |||
{{ answer.text }} | |||
</NcCheckboxRadioSwitch> | |||
<div v-if="allowOtherAnswer" class="question__other-answer"> | |||
<NcCheckboxRadioSwitch :checked.sync="questionValues" | |||
<NcCheckboxRadioSwitch :checked.sync="values" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not valid, you shall not modify properties (values
is a property so you should instead only set it like :checked="values"
but handle the update with a method like @update:values="onValuesChange"
Yes thats at least the reason for the backend issues, for the front end the code was not that error resilient. |
@Chartman123 Is the problem still there? Can you provide examples of how to reproduce? |
@AIlkiv we could already fix it :) it was introduced with my change of the backend to fix XML output |
Signed-off-by: Christian Hartmann chris-hartmann@gmx.de