Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix submission of other answers #1760

Closed
wants to merge 1 commit into from
Closed

Conversation

Chartman123
Copy link
Collaborator

Signed-off-by: Christian Hartmann chris-hartmann@gmx.de

Signed-off-by: Christian Hartmann <chris-hartmann@gmx.de>
@Chartman123 Chartman123 added bug Something isn't working php PHP related ticket javascript Javascript related ticket high High priority labels Oct 25, 2023
@Chartman123 Chartman123 added this to the 3.4 milestone Oct 25, 2023
@Chartman123 Chartman123 self-assigned this Oct 25, 2023
@Chartman123
Copy link
Collaborator Author

@AIlkiv Perhaps you could also have another look at this. Current main is broken if you allow custom answers and also the validation on the server side. Statistics are also not counted correctly.

@susnux This is my first attempt to fix the problem that I told you about.

I'm currently not really sure where this is coming from, might be my change that fixed the output for XML in #1705

@@ -62,7 +62,7 @@
{{ answer.text }}
</NcCheckboxRadioSwitch>
<div v-if="allowOtherAnswer" class="question__other-answer">
<NcCheckboxRadioSwitch :checked.sync="questionValues"
<NcCheckboxRadioSwitch :checked.sync="values"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not valid, you shall not modify properties (values is a property so you should instead only set it like :checked="values" but handle the update with a method like @update:values="onValuesChange"

@susnux
Copy link
Collaborator

susnux commented Oct 26, 2023

I'm currently not really sure where this is coming from, might be my change that fixed the output for XML in #1705

Yes thats at least the reason for the backend issues, for the front end the code was not that error resilient.

@Chartman123 Chartman123 deleted the fix/submit-other-answer branch October 26, 2023 17:33
@AIlkiv
Copy link
Collaborator

AIlkiv commented Oct 29, 2023

@Chartman123 Is the problem still there? Can you provide examples of how to reproduce?

@Chartman123
Copy link
Collaborator Author

@AIlkiv we could already fix it :) it was introduced with my change of the backend to fix XML output

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2. developing Work in progress bug Something isn't working feature: 📊 responses & statistics feature: 📝 submitting responses high High priority javascript Javascript related ticket php PHP related ticket
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants