Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix expiration display #326

Merged
merged 1 commit into from
May 3, 2020
Merged

Fix expiration display #326

merged 1 commit into from
May 3, 2020

Conversation

skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented May 1, 2020

Kazam_screenshot_00014
Kazam_screenshot_00015
Kazam_screenshot_00016

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv skjnldsv added bug Something isn't working design Related to the design 3. to review Waiting for reviews feature: 👥 sharing settings labels May 1, 2020
@skjnldsv skjnldsv added this to the 2.0 milestone May 1, 2020
@skjnldsv skjnldsv self-assigned this May 1, 2020
@codecov-io

This comment has been minimized.

@jotoeri
Copy link
Member

jotoeri commented May 1, 2020

  • Hm, i still don't think the checkmark is reasonable to mark as expired... 🤔
  • Can we disable typing on the field? When manually changing the text, expires falls back to 1970.

@skjnldsv
Copy link
Member Author

skjnldsv commented May 1, 2020

  • Hm, i still don't think the checkmark is reasonable to mark as expired... thinking

See with @jancborchardt ;)

  • Can we disable typing on the field? When manually changing the text, expires falls back to 1970.

Good call!

@jancborchardt
Copy link
Member

  • Hm, i still don't think the checkmark is reasonable to mark as expired... thinking

See with @jancborchardt ;)

So @skjnldsv and I both discussed in a design review and it’s already more understandable than the colors. Not perfect, but what is ever? Let’s take small steps as always. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working design Related to the design feature: 👥 sharing settings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants