Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Result View #341

Merged
merged 9 commits into from
May 5, 2020
Merged

New Result View #341

merged 9 commits into from
May 5, 2020

Conversation

jotoeri
Copy link
Member

@jotoeri jotoeri commented May 4, 2020

Ok, so this is the current state of my result-view branch.

grafik

appinfo/routes.php Outdated Show resolved Hide resolved
@codecov-io

This comment has been minimized.

@jotoeri jotoeri requested a review from skjnldsv May 4, 2020 12:47
@skjnldsv
Copy link
Member

skjnldsv commented May 4, 2020

@jancborchardt is it time to introduce cards to Nextcloud?

@skjnldsv
Copy link
Member

skjnldsv commented May 5, 2020

  • @skjnldsv I think i would not use the Question-vue-files, to make them not too complex with statistics etc., but use separate files for results. What do you think?

If we're talking abou the individual view per submission, yes, you should use them, it should look the same as when the user filled the submit form :)

src/components/TopBar.vue Outdated Show resolved Hide resolved
src/views/Results.vue Outdated Show resolved Hide resolved
@jancborchardt
Copy link
Member

@jancborchardt is it time to introduce cards to Nextcloud?

Where it makes sense we already use them (Deck, Bookmarks). Here it doesn’t really as they will be full width anyway. Try with an actual survey with real data, that is long questions and possibly long responses. :)

Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed the heading style and moved the actions more relevant and discoverable below the heading again. Good to go from my side! :)
Forms responses

@jancborchardt
Copy link
Member

Next important step would be to include the Summary-View including statistics. (Maybe i do on a separate PR to keep this one small? Then this one would be to review...)

Yes this should absolutely be separate. :)

@jancborchardt
Copy link
Member

Added some more detail fixes, this is definitely good to go now. :)

jotoeri and others added 9 commits May 5, 2020 18:30
Signed-off-by: Jonas Rittershofer <jotoeri@users.noreply.github.com>
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
Signed-off-by: Jonas Rittershofer <jotoeri@users.noreply.github.com>
Signed-off-by: Jonas Rittershofer <jotoeri@users.noreply.github.com>
Signed-off-by: Jonas Rittershofer <jotoeri@users.noreply.github.com>
Signed-off-by: Jonas Rittershofer <jotoeri@users.noreply.github.com>
Co-authored-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
Signed-off-by: Jonas Rittershofer <jotoeri@users.noreply.github.com>
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
@jotoeri
Copy link
Member Author

jotoeri commented May 5, 2020

So - final state?
grafik

Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff, let’s get it in! :)

@jotoeri jotoeri added 3. to review Waiting for reviews and removed 2. developing Work in progress labels May 5, 2020
@jotoeri jotoeri merged commit c6b515f into master May 5, 2020
@jotoeri jotoeri deleted the enh/result_view branch May 5, 2020 19:01
@Spartachetto
Copy link

If I get well this issue, it could be worthwhile to look at #11 and have the feedback from @Rello

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
6 participants