-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Result View #341
New Result View #341
Conversation
This comment has been minimized.
This comment has been minimized.
@jancborchardt is it time to introduce cards to Nextcloud? |
If we're talking abou the individual view per submission, yes, you should use them, it should look the same as when the user filled the submit form :) |
Where it makes sense we already use them (Deck, Bookmarks). Here it doesn’t really as they will be full width anyway. Try with an actual survey with real data, that is long questions and possibly long responses. :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes this should absolutely be separate. :) |
Added some more detail fixes, this is definitely good to go now. :) |
Signed-off-by: Jonas Rittershofer <jotoeri@users.noreply.github.com>
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
Signed-off-by: Jonas Rittershofer <jotoeri@users.noreply.github.com>
Signed-off-by: Jonas Rittershofer <jotoeri@users.noreply.github.com>
Signed-off-by: Jonas Rittershofer <jotoeri@users.noreply.github.com>
Signed-off-by: Jonas Rittershofer <jotoeri@users.noreply.github.com> Co-authored-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
Signed-off-by: Jonas Rittershofer <jotoeri@users.noreply.github.com>
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great stuff, let’s get it in! :)
Ok, so this is the current state of my result-view branch.
@skjnldsv I think i would not use the Question-vue-files, to make them not too complex with statistics etc., but use separate files for results. What do you think?