Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct fix window title #375

Merged
merged 1 commit into from
May 10, 2020
Merged

Correct fix window title #375

merged 1 commit into from
May 10, 2020

Conversation

jotoeri
Copy link
Member

@jotoeri jotoeri commented May 10, 2020

Like this, @skjnldsv ? ;)

  • Also changed to the new computed formTitle property, that Jan introduced. Can one of you check, if the title()-property in Create.vue really was deprecated? I looked through and didn't find a usage, but just to make sure i didn't miss anything.

@jotoeri jotoeri added bug Something isn't working 3. to review Waiting for reviews labels May 10, 2020
jancborchardt
jancborchardt approved these changes May 10, 2020
View reviewed changes
Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just the fixup needs to be fixed. :)

@jotoeri
Correct fix window title
3c973b1 
Signed-off-by: Jonas Rittershofer <jotoeri@users.noreply.github.com>
@jotoeri
Copy link
Member Author

jotoeri commented May 10, 2020

Jup, was for easier review. ;)
Squashed & pushed. 👍

@codecov-io
Copy link

Codecov Report

Merging #375 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##             master    #375   +/-   ##
========================================
  Coverage      0.00%   0.00%           
  Complexity      195     195           
========================================
  Files            17      17           
  Lines          1061    1061           
========================================
  Misses         1061    1061

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a3079b5...3c973b1. Read the comment docs.

@jancborchardt jancborchardt merged commit 95cd4c0 into master May 10, 2020
@jancborchardt jancborchardt deleted the fix/window_title branch May 10, 2020 18:11
@jancborchardt jancborchardt added this to the 2.0 milestone May 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jancborchardt jancborchardt jancborchardt approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

Assignees
No one assigned
Labels
3. to review Waiting for reviews bug Something isn't working
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.
4 participants
@jotoeri @codecov-io @jancborchardt @skjnldsv