Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort Navigation newest forms first #402

Merged
merged 1 commit into from
May 22, 2020
Merged

Sort Navigation newest forms first #402

merged 1 commit into from
May 22, 2020

Conversation

jotoeri
Copy link
Member

@jotoeri jotoeri commented May 20, 2020

Now showing newest forms on top and adding new forms on top of the forms-list.

Closes #401

Signed-off-by: Jonas Rittershofer <jotoeri@users.noreply.github.com>
@jotoeri jotoeri added enhancement New feature or request 3. to review Waiting for reviews labels May 20, 2020
@jotoeri jotoeri added this to the 2.0 milestone May 20, 2020
@codecov-commenter
Copy link

Codecov Report

Merging #402 into master will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##             master    #402   +/-   ##
========================================
  Coverage      0.00%   0.00%           
  Complexity      195     195           
========================================
  Files            17      17           
  Lines          1063    1066    +3     
========================================
- Misses         1063    1066    +3     
Impacted Files Coverage Δ Complexity Δ
lib/Db/FormMapper.php 0.00% <0.00%> (ø) 5.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8441787...a06d028. Read the comment docs.

Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jotoeri could we use ordering by "modified", that would result in a more relevant sorting over time. :)

Also not sure if easily possible, but Forms with recent replies could also be sorted up top so you directly see that something happened. Just like for Talk conversations.

@jotoeri
Copy link
Member Author

jotoeri commented May 22, 2020

Hm, we don't store such a date yet...

Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, we don't store such a date yet...

In that case let’s get this one in. :) Works nicely and looks much better!

@jancborchardt jancborchardt merged commit c08afe9 into master May 22, 2020
@jancborchardt jancborchardt deleted the enh/sort_forms branch May 22, 2020 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews enhancement New feature or request feature: 📑 form creation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sort Navigation
3 participants