-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Put AppNavigationItems into proper Container #406
Conversation
d0d4167
to
9c888e4
Compare
Signed-off-by: Jonas Rittershofer <jotoeri@users.noreply.github.com>
9c888e4
to
81e5970
Compare
Codecov Report
@@ Coverage Diff @@
## master #406 +/- ##
========================================
Coverage 0.00% 0.00%
Complexity 195 195
========================================
Files 17 17
Lines 1066 1066
========================================
Misses 1066 1066 Continue to review full report at Codecov.
|
👍 Just waiting for a vue release. :) |
Is there a Vue component release with nextcloud-libraries/nextcloud-vue#1107 already in so we can merge? :) |
We need a new vue release, and update the dependency with this pr as well :) |
Is there a new Vue release meanwhile, or when would that happen? :) |
Maybe especially nextcloud-libraries/nextcloud-vue#1123 would be good to merge before a vue-release, as it avoids breaking other apps after my Navigation-PR. |
So we merge 1123 and release? :) |
Even the other ones on vue-repo are no big things... ;) |
Puts the App-NavigationItems into a list, therefore decoupling the navigation from Body.
Best visible when having a long list of forms, that now has its own scrollbar and does (for the first moment) not scroll with the content.
Depends on nextcloud-libraries/nextcloud-vue#1107