Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put AppNavigationItems into proper Container #406

Merged
merged 1 commit into from
Jun 18, 2020

Conversation

jotoeri
Copy link
Member

@jotoeri jotoeri commented May 22, 2020

Puts the App-NavigationItems into a list, therefore decoupling the navigation from Body.
Best visible when having a long list of forms, that now has its own scrollbar and does (for the first moment) not scroll with the content.

Depends on nextcloud-libraries/nextcloud-vue#1107

@jotoeri jotoeri added enhancement New feature or request pending fix Waiting for a fix on one of our dependencies 3. to review Waiting for reviews feature: 📑 form creation labels May 22, 2020
@jotoeri jotoeri added this to the 2.0 milestone May 22, 2020
Signed-off-by: Jonas Rittershofer <jotoeri@users.noreply.github.com>
@codecov-commenter
Copy link

Codecov Report

Merging #406 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##             master    #406   +/-   ##
========================================
  Coverage      0.00%   0.00%           
  Complexity      195     195           
========================================
  Files            17      17           
  Lines          1066    1066           
========================================
  Misses         1066    1066           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4b5ea0...81e5970. Read the comment docs.

@jotoeri jotoeri added the Do not merge Don't merge, as it will break master (e.g. due to pending dependency) label May 25, 2020
@jotoeri
Copy link
Member Author

jotoeri commented May 25, 2020

👍 Just waiting for a vue release. :)

@jotoeri jotoeri added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels May 25, 2020
@jancborchardt
Copy link
Member

Is there a Vue component release with nextcloud-libraries/nextcloud-vue#1107 already in so we can merge? :)

@skjnldsv
Copy link
Member

skjnldsv commented Jun 5, 2020

We need a new vue release, and update the dependency with this pr as well :)

@jancborchardt
Copy link
Member

Is there a new Vue release meanwhile, or when would that happen? :)

@jotoeri
Copy link
Member Author

jotoeri commented Jun 9, 2020

Maybe especially nextcloud-libraries/nextcloud-vue#1123 would be good to merge before a vue-release, as it avoids breaking other apps after my Navigation-PR.
If we further get the other PRs done, we would only need one vue-release for our forms stuff there. ;)

@skjnldsv
Copy link
Member

Maybe especially nextcloud/nextcloud-vue#1123 would be good to merge before a vue-release, as it avoids breaking other apps after my Navigation-PR.

So we merge 1123 and release? :)

@jotoeri
Copy link
Member Author

jotoeri commented Jun 10, 2020

Maybe especially nextcloud/nextcloud-vue#1123 would be good to merge before a vue-release, as it avoids breaking other apps after my Navigation-PR. If we further get the other PRs done, we would only need one vue-release for our forms stuff there. ;)

So we merge 1123 and release? :)

Even the other ones on vue-repo are no big things... ;)

@jotoeri jotoeri removed the Do not merge Don't merge, as it will break master (e.g. due to pending dependency) label Jun 18, 2020
@jotoeri jotoeri removed the pending fix Waiting for a fix on one of our dependencies label Jun 18, 2020
@jotoeri jotoeri merged commit cc31df8 into master Jun 18, 2020
@jotoeri jotoeri deleted the enh/navigation_container branch June 18, 2020 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish enhancement New feature or request feature: 📑 form creation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants